Bug 122582 - kpilot icon is not installed during make install
Summary: kpilot icon is not installed during make install
Status: RESOLVED FIXED
Alias: None
Product: kpilot
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: groot
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-23 19:47 UTC by Joseph Tate
Modified: 2007-03-20 05:16 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Tate 2006-02-23 19:47:59 UTC
Version:            (using KDE KDE 3.5.1)
Installed from:    Compiled From Sources
Compiler:          GCC 3.4.4 
OS:                Linux

The file kpilot.gif exists in the source tarball, and is referenced by the Makefile for make dist, but is not installed.

I'm not sure if it refers to kpilot.gif, but the kpilot.desktop refers to a kpilot Icon.  There are icons provided by the kdeartwork tarball, but kpilot should provide a default so that kdeartwork is not required.  There is no kpilot.* icon in /usr/share/ after I finish running make install.
Comment 1 groot 2006-02-23 23:02:50 UTC
On Thursday 23 February 2006 19:48, Joseph Tate wrote:
> The file kpilot.gif exists in the source tarball, and is referenced by the
> Makefile for make dist, but is not installed.


It's an ancient file that should have been removed.

> I'm not sure if it refers to kpilot.gif, but the kpilot.desktop refers to a
> kpilot Icon.  There are icons provided by the kdeartwork tarball, but
> kpilot should provide a default so that kdeartwork is not required.  There
> is no kpilot.* icon in /usr/share/ after I finish running make install.


There are hicolor (fallback icon theme) icons for KPilot - those should be 
installed.
Comment 2 Joseph Tate 2006-02-24 17:44:39 UTC
Ok.  kpilot.desktop is not the culprit here.  I'm sorry for poorly reporting the bug.  The real issue is that kpilotdaemon.desktop has an Icon reference for kpilot.xpm which doesn't exist anywhere.

The following patch seems to work:

--- kpilot/kpilot/kpilotdaemon.desktop.orig     2006-02-24 11:44:05.000000000 -0500
+++ kpilot/kpilot/kpilotdaemon.desktop  2006-02-24 11:44:10.000000000 -0500
@@ -35,7 +35,7 @@
 Name[zu]=KUmshayeli webhanoyi Daemon
 Exec=kpilotDaemon
 NoDisplay=true
-Icon=kpilot.xpm
+Icon=kpilotdaemon
 Type=Application
 Terminal=false
 X-DCOP-ServiceType=Unique
Comment 3 Jason 'vanRijn' Kasper 2007-03-20 05:16:41 UTC
Hi Joseph,

Thanks for the bug report.  I'll commit this for the upcoming 3.5.7 release, but I'm changing it from kpilotdaemon to kpilot for the Icon=.  =:)

Thanks!!!