Bug 121651 - export menu not available in context menu from album
Summary: export menu not available in context menu from album
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Menus (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-09 16:04 UTC by Matthieu Moy
Modified: 2017-07-29 06:22 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 0.9.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthieu Moy 2006-02-09 16:04:32 UTC
Version:           0.8 (using KDE KDE 3.5.1KDE 3.4.2KDE 3.4.2)
Installed from:    Fedora RPMs00Fedora RPMs

In the Album menu from the menubar, export appears just next to import, which is nice.

Why isn't this the case for the context menu obtained by right-clicking on an album?
Comment 1 caulier.gilles 2006-02-09 16:11:23 UTC
Because this option have been removed since a long time from album content menu to reduce menu size.

If this option is always availab from Album context menu then we have forget to remove it (:=)))

Any viewpoint about this point ?

Gilles Caulier
Comment 2 Matthieu Moy 2006-02-09 16:20:46 UTC
Well, to export an album, I want to click on this album. Clicking on the album, and then moving up to the menubar doesn't seem very natural. In fact, I can see no reason to have the context menu different from the Album menu of the menubar (except the global option like "quit", which have actually nothing to do in an "Album" menu - but that you expect at the end of the first item of the menubar for some reason).

Furthermore, for me, export is the dual of import. So, wherever I see "import", I want to see an "export" just beside (well, like in the Album menu from the menubar).
Comment 3 caulier.gilles 2006-12-11 14:29:45 UTC
SVN commit 612444 by cgilles:

digikam from trunk : add Export menu into Album context pop-up menu.
BUG: 121651

 M  +14 -0     albumfolderview.cpp  
 M  +5 -0      digikamapp.cpp  
 M  +1 -0      digikamapp.h  


--- trunk/extragear/graphics/digikam/digikam/albumfolderview.cpp #612443:612444
@@ -414,6 +414,7 @@
 void AlbumFolderView::slotContextMenu(QListViewItem *listitem, const QPoint &, int)
 {
     KActionMenu menuImport(i18n("Import"));
+    KActionMenu menuExport(i18n("Export"));
     KActionMenu menuKIPIBatch(i18n("Batch Processes"));
 
     KPopupMenu popmenu(this);
@@ -460,6 +461,19 @@
             menuImport.plug(&popmenu);
         }
 
+        // Add All Export Actions
+        const QPtrList<KAction> exportActions = DigikamApp::getinstance()->menuExportActions();
+        if(!exportActions.isEmpty())
+        {
+            QPtrListIterator<KAction> it4(exportActions);
+            while((action = it4.current()))
+            {
+                menuExport.insert(action);
+                ++it4;
+            }
+            menuExport.plug(&popmenu);
+        }
+
         // Add KIPI Batch processes plugins Actions
         const QPtrList<KAction>& batchActions = DigikamApp::getinstance()->menuBatchActions();
         if(!batchActions.isEmpty())
--- trunk/extragear/graphics/digikam/digikam/digikamapp.cpp #612443:612444
@@ -283,6 +283,11 @@
     return importMenu;
 }
 
+const QPtrList<KAction> DigikamApp::menuExportActions()
+{
+    return m_kipiFileActionsExport;
+}
+
 void DigikamApp::autoDetect()
 {
     // Called from main if command line option is set
--- trunk/extragear/graphics/digikam/digikam/digikamapp.h #612443:612444
@@ -90,6 +90,7 @@
     const QPtrList<KAction>& menuAlbumActions();
     
     const QPtrList<KAction> menuImportActions();
+    const QPtrList<KAction> menuExportActions();
 
     void autoDetect();
     void downloadFrom(const QString &cameraGuiPath);