Version: 1.3.8 (using KDE KDE 3.5.0) Installed from: Slackware Packages Here is a patch that adds audio cd playback support to the xine backend of amarok. I've tried to minimize changes and to comment them as much as possible... I hope you will find it useful... for me it works quite well (it can play audio cds even if the cdrom drive is not attached to the soundcard, and has cddb support as well - all thanks to xine)
Created attachment 14620 [details] patch to add audiocd playback to xine-engine
Sorry, Alberto, the patch does not apply cleanly to amaroK 1.4. Too much has changed :( amaroK 1.3 is feature frozen, so it's useless for 1.3. Could you check out 1.4 from SVN, and adapt the patch?
> Sorry, Alberto, the patch does not apply cleanly to amaroK 1.4. Too much has changed :( amaroK 1.3 is feature frozen, so it's useless for 1.3. > > Could you check out 1.4 from SVN, and adapt the patch? I'll try to do my best... Cheers, Alberto
Created attachment 14627 [details] patch adapted to amarok 1.4svn Here you are, I adapted it and it seems to work now for the 1.4svn (checkout of yesterday)
SVN commit 507922 by markey: AudioCD (CDDA) support for xine-engine, including CDDB lookup. Patch by Alberto Griggio <alberto.griggio@gmail.com>. Many thanks, Alberto, this seems to work well :) FEATURE: 121647 M +2 -0 ChangeLog M +47 -0 src/app.cpp M +15 -0 src/collectiondb.cpp M +24 -0 src/engine/enginebase.h M +5 -0 src/engine/xine/xine-config.cpp M +65 -1 src/engine/xine/xine-engine.cpp M +4 -0 src/engine/xine/xine-engine.h M +117 -1 src/engine/xine/xineconfigbase.ui M +11 -4 src/playlistwindow.cpp
Just looking at the patch, it looks good. Another legitimate longtime user-gripe is now solved in 1.4.
Well, thanks :-) Next step would be to implement it for other engines as well: I think that it can be done for gstreamer without too much effort, and I'll try to when I find some time (no promise though...)
This still does not work for me in 1.4. It recognizes the CD, and can tell me all of the tracks (and get CDDB) but can't play anything. The cdplay command can play the cd though.
This works for me now in 1.4. I'm guessing it was some brokenness in Debian's libasound2 1.0.11-5 (http://bugs.debian.org/369040) or 1.0.11-6 (http://bugs.debian.org/369412)