Bug 121319 - Saved kst file contains child information in multiple places
Summary: Saved kst file contains child information in multiple places
Status: RESOLVED FIXED
Alias: None
Product: kst
Classification: Applications
Component: general (show other bugs)
Version: 1.x
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-03 20:11 UTC by Andrew Walker
Modified: 2006-02-09 00:47 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Fixes creation of .kst files (10.62 KB, patch)
2006-02-03 20:30 UTC, Andrew Walker
Details
fix-saving-children.patch (8.79 KB, text/x-diff)
2006-02-05 21:25 UTC, George Staikos
Details
fix-saving-children.patch (9.50 KB, text/x-diff)
2006-02-06 00:02 UTC, George Staikos
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Walker 2006-02-03 20:11:54 UTC
Version:           HEAD (using KDE KDE 3.5.0)
Installed from:    Compiled From Sources
OS:                Linux

PROBLEM:
Whan saving a .kst file where at least one plot has a child view object the information about the child view object is saved in multiple places within the .kst file

STEPS TO REPRODUCE:
Start Kst
Create a single plot
Create a rectangle object within the plot
Save to a .kst file

RESULTS:
The information on the rectangle object is saved twice in the file

EXPECTED RESULTS:
The information should be saved only once
Comment 1 Andrew Walker 2006-02-03 20:30:38 UTC
Created attachment 14532 [details]
Fixes creation of .kst files
Comment 2 George Staikos 2006-02-05 21:25:52 UTC
Here is an updated patch that removes some things that don't need to be in it 
or shouldn't be in it.  Remaining problems:

- Labels from 1.1 and below don't show up until the parent plot is resized
- Plot groups from 1.1 can't be loaded


Created an attachment (id=14563)
fix-saving-children.patch
Comment 3 George Staikos 2006-02-06 00:02:38 UTC
Updated patch fixes plot groups.

Labels may not be a loading issue as much as a problem with labels and/or the 
contentsRect relative positioning.


Created an attachment (id=14566)
fix-saving-children.patch
Comment 4 George Staikos 2006-02-09 00:47:17 UTC
SVN commit 507302 by staikos:

andrew's saving patch, with a fixme added back, an irrelevant hunk removed, and
legacy plotgroup loading fixed.  reviewed by Barth
BUG: 121319


 M  +14 -5     kst2dplot.cpp  
 M  +2 -1      kst2dplot.h  
 M  +12 -1     kstborderedviewobject.cpp  
 M  +2 -0      kstborderedviewobject.h  
 M  +3 -8      kstdoc.cpp  
 M  +1 -6      ksttoplevelview.cpp  
 M  +12 -37    kstviewobject.cpp  
 M  +1 -3      kstviewobject.h