Bug 120576 - Can't edit filter parameters
Summary: Can't edit filter parameters
Status: RESOLVED FIXED
Alias: None
Product: kst
Classification: Applications
Component: general (show other bugs)
Version: 1.x
Platform: unspecified Linux
: VHI normal
Target Milestone: ---
Assignee: kst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-22 00:16 UTC by Netterfield
Modified: 2006-01-24 20:05 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Netterfield 2006-01-22 00:16:49 UTC 
Version:           1.2.0_devel (using KDE 3.4.3, Gentoo)
Compiler:          gcc version 3.3.6 (Gentoo 3.3.6, ssp-3.3.6-1.0, pie-8.7.8)
OS:                Linux (i686) release 2.6.14-gentoo-r5

Create a plot with a curve...
rmb->filter. 
Select a filter (eg, lowpass filter, default parameters).

The filtered curve is added to the plot.  Happiness.

Now attempt to edit the plugin (eg, from the data manager).  

PROBLEM:
The plugin dialog has nowhere to adjust the filter parameters.

CORRECT Behavior:
The plugin dialog should include the filter parameters.
Comment 1 Netterfield 2006-01-22 00:17:46 UTC 
showstopper for 1.2
Comment 2 Andrew Walker 2006-01-24 19:20:07 UTC 
This is not specific to filters but applies to all plugins.
Comment 3 Andrew Walker 2006-01-24 20:01:24 UTC 
It appears to be the call to show() in KstPluginDialogI::fillFieldsForEdit()
that is causing the dialog to be essentially reset to the default plugin (linefit). The is because KstDataDialog::show() calls fillFieldsForNew().
Comment 4 Andrew Walker 2006-01-24 20:05:57 UTC 
SVN commit 502058 by arwalker:

BUG:120576 Remove unnecessary call to show() in fillFieldsForEdit().

 M  +0 -1      kstplugindialog_i.cpp  


--- trunk/extragear/graphics/kst/kst/kstplugindialog_i.cpp #502057:502058
@@ -170,7 +170,6 @@
   _w->PluginCombo->setEnabled(pp->getUsage() < 3);
   pp->readUnlock();
 
-  show();
   fixupLayout();
 }