Version: (using KDE KDE 3.5.0) Installed from: Compiled From Sources The color for highlighting in the tab bar has thankfully been made configurable -- I would like to request that in its default, unhighlighted state, to have it use the color for text defined by KDE's color scheme, instead of hardcoding it black. (This is because I happen to use a black background; black on black is not the most readable of combinations.) Or make it configurable along with the rest of the highlight colors, if you swing that way.
I'll make it use the text color.
SVN commit 498296 by hein: * Use color scheme "Standard Text" colour as tab text default colour, consistent with Konqueror and Kopete. * Pick up global colour palette changes accordingly. BUG:120159 M +1 -3 konversationapplication.cpp M +2 -2 konversationmainwindow.cpp --- trunk/extragear/network/konversation/src/konversationapplication.cpp #498295:498296 @@ -125,6 +125,7 @@ connect(this, SIGNAL(prefsChanged()), mainWindow, SIGNAL(prefsChanged()) ); // take care of user style changes, setting back colors and stuff connect(KApplication::kApplication(), SIGNAL(appearanceChanged()), mainWindow, SLOT(updateAppearance())); + connect(KApplication::kApplication(), SIGNAL(appearanceChanged()), mainWindow, SLOT(updateTabNotifications())); // apply GUI settings mainWindow->updateAppearance(); @@ -910,10 +911,7 @@ emit prefsChanged(); if(updateGUI) - { - mainWindow->updateAppearance(); emit appearanceChanged(); - } } void KonversationApplication::updateNickIcons() --- trunk/extragear/network/konversation/src/konversationmainwindow.cpp #498295:498296 @@ -1058,7 +1058,7 @@ } } - getViewContainer()->setTabColor(view, QColor()); + getViewContainer()->setTabColor(view, colorGroup().text()); } void KonversationMainWindow::updateTabNotifications() @@ -1092,7 +1092,7 @@ for(int i = 0; i < viewContainer->count(); ++i) { ChatWindow* view = static_cast<ChatWindow*>(viewContainer->page(i)); - getViewContainer()->setTabColor(view, QColor()); + getViewContainer()->setTabColor(view, colorGroup().text()); } }
Wow, that was fast :)
I actually used the wrong colour first (what I did was consistent with Konqueror and Kopete but, the correct colour to use here is the foreground rather than the text color - evil Konq! :), so there's a check-in after this that improves on it. Also another small corner case fix for dynamically picking up global colour palette changes. Enjoy!