Bug 120024 - Re-add the "Delete folder" entry to the RMB popup menu.
Summary: Re-add the "Delete folder" entry to the RMB popup menu.
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Unmaintained
Component: keys and menus (show other bugs)
Version: 1.9
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
: 123572 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-01-13 10:46 UTC by Andrey Cherepanov
Modified: 2007-09-14 12:17 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Cherepanov 2006-01-13 10:46:41 UTC
Version:           1.9 (using KDE 3.5.0, compiled sources)
Compiler:          gcc version 3.4.4 20050721 (Red Hat 3.4.4-2)
OS:                Linux (i686) release 2.6.9-1.667smp

In KMail 1.9 (KDE 3.5) I cannot delete any mail folder from their context menu or by pressing Delete key. When I move foler to Trash and empty Trash this folder is still exist. Please, return "Delete" action for the folder context menu. In early version of KMail I can delete any user folder without any problem.
Comment 1 Carsten Burghardt 2006-01-13 11:39:33 UTC
In the menu: Folder -> Delete
Comment 2 markus 2006-01-25 20:03:51 UTC
This is a severe regression. The usability of my KMail has suffered badly through this. Deleting a folder has the same importance as creating a folder. Though, the delete function is now missing. 

Please reimplement the delete function!!!! 

And please don't set this issue to "resolved"!!! It isn't!!! A bad decision may explain this problem, but the explanation won't resolve it!
Comment 3 Thiago Macieira 2006-01-27 14:43:04 UTC
It's not missing. It's just not in the RMB popup menu anymore.
Comment 4 markus 2006-01-27 16:54:58 UTC
Thiago,
your point is weak: So if "delete folder" is no longer in the popup menu, why do you leave "create folder" there? 

I would expect to find a "delete" function near to the place where I can find the "create" function. 

KMail has become a great bit less intuitive by the decision to remove the delete function.

Please rethink this decision. It was a bad decision and I really cannot see your point. Ask your Mom: She won't follow you either. :-)
Comment 5 Johann-Nikolaus Andreae 2006-01-28 12:14:58 UTC
I also missing the delete folder in the RMB popup menu.
Comment 6 Iñaki Baz Castillo 2006-01-28 18:10:35 UTC
I agree with this wish. I use Kmail from 2 years ago and when upgrading to an actual version I couldn't believe that I cannot delete a folder. After many time I discovered this option in "Folder" menu in the top bar, but I don't like it.
Comment 7 Natia Kipiani 2006-01-28 18:57:41 UTC
I also miss this feature!
Comment 8 Florian Jostock 2006-01-29 13:46:24 UTC
I did not find the Delete-Folder Dunction and instead moved them to Trash... 

In the "Folder" menu in the top bar, the item is far away from "create Folder" - so i didn't find it there until I found a link to this bug on the mailinglist.
Comment 9 Markus Feilner 2006-01-30 00:41:35 UTC
Deletion and creation of folders must be at the same place, at best we should have it twice both in context menu AND main menu. However, every user will first look for it in the right-click context menu. PLEASE RE-CHANGE THIS! Million thanks for Kontact+Kmail, great pieces of software - wonderful!!!
Comment 10 T. Ribbrock 2006-01-30 08:41:03 UTC
I have to agree with the previous comments - the only logical place for a "delete" function is near the place where the corresponding "create" function is. This is the principle of least surprise. Hence, my vote to put "delete" back to where it belongs, i.e. in the context menu.
Comment 11 Thiago Macieira 2006-01-31 18:42:43 UTC
Reopening and retitling. I agree with this change, actually. Maybe the number of votes will convince the usability people that this feature is really wanted and should be in the RMB, not hidden in the Folder menu.
Comment 12 Iñaki Baz Castillo 2006-01-31 19:17:25 UTC
Thanks a lot!

Anyway, I think the problem is not only with the "Delete Folder" location. 

There is another "old" wish called:
  "Folder Menu and Context Menu of a Folder should be the same"
   http://bugs.kde.org/show_bug.cgi?id=92905

I've posted there my opinion.
Comment 13 Reinhold Kainhofer 2006-01-31 19:42:59 UTC
Am Dienstag, 31. Januar 2006 18:42 schrieb Thiago Macieira:
> Reopening and retitling. I agree with this change, actually. Maybe the
> number of votes will convince the usability people that this feature is
> really wanted and should be in the RMB, not hidden in the Folder menu.


It was not really the usability people who suggested the change. It was Will 
with the argument that such a destructive action shouldn't be in the RMB 
menu. It's just that TomasZ agreed (so don't blame it on all usability 
people!).

Cheers,
Reinhold

PS: I also find the absence really annoying as it is totally inconsistent with 
every other RMB menu where you have a delete item.
Comment 14 Allen Winter 2006-02-13 21:29:29 UTC
SVN commit 509156 by winterz:

Back by popular demand (votes), approved by Ingo and Till, we undo
revision 450009.  The "Delete Folder" menu selection is now restored.

Also added a separator above this selection so it stands out a little better,
as suggested by Ellen on the usability list.

BUGS: 120024



 M  +4 -0      kmfoldertree.cpp  


--- branches/KDE/3.5/kdepim/kmail/kmfoldertree.cpp #509155:509156
@@ -1020,6 +1020,10 @@
       mMainWidget->action("compact")->plug(folderMenu);
 
       folderMenu->insertSeparator();
+      if ( !fti->folder()->isSystemFolder() )
+        mMainWidget->action("delete_folder")->plug(folderMenu);
+
+      folderMenu->insertSeparator();
       mMainWidget->action("empty")->plug(folderMenu);
       folderMenu->insertSeparator();
     }
Comment 15 Ismail Onur Filiz 2006-03-13 22:07:57 UTC
*** Bug 123572 has been marked as a duplicate of this bug. ***