Bug 118157 - Filter classify as spam and ham don't appear in toolbar
Summary: Filter classify as spam and ham don't appear in toolbar
Status: RESOLVED NOT A BUG
Alias: None
Product: kmail
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-12 03:49 UTC by David Jarvie
Modified: 2008-01-30 09:41 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Jarvie 2005-12-12 03:49:07 UTC
Version:            (using KDE KDE 3.5.0)
Installed from:    Compiled From Sources
Compiler:          gcc 4.0.1 
OS:                Linux

I can't get the "Filter classify as spam" or "Filter classify as ham" actions to appear in the toolbar. I have tried both the Configure Toolbar method, and, after reading bug 117356, also toggling the "Additionally add this filter to the toolbar" option in the filters configuration dialog Advanced tab. The Configure Toolbars dialog shows them as being in the toolbar, but they don't appear in the actual toolbar.
Comment 1 Andreas Gungl 2005-12-12 20:16:45 UTC
Try taking the actions out of the toolbar via the toolbar configuration 
dialog. Check, whether the action list toolbar_filter_actions is included in 
the toolbar. If yes, toggling the appropriate option in the filter settings 
dialog should affect the toolbar.

You can also try to move away your kmmainwin.rc and start KMail w/o that file 
(falling back to the default toolbar settings).
Comment 2 David Jarvie 2005-12-14 00:08:01 UTC
Removing the actions from the toolbar via the configuration dialogue didn't work. There was no toolbar_filter_actions in the list. I then toggled the filter settings  options, but that didn't work either. Restarting without kmmainwin.rc solved it.

I had transferred some kmail config files from my KDE 3.4 installation, which had spam filter options enabled. After installing KDE 3.5, the spam buttons originally showed up with the default icon on them (i.e. the KDE default icon). I then ran the spam wizard which gave me two sets of spam filter actions. I then removed the filter_actions list using the configure toolbars dialogue. The fault occurred after that, when I tried to add the new buttons. So I suspect that the upgrade to KDE 3.5 may have caused the problem due to bugs in the config upgrade. Whatever the cause, I hope it can be fixed for KDE 3.5.1 so that non-technical users can avoid this sort of stumbling block.
Comment 3 Andreas Gungl 2005-12-14 10:03:43 UTC
Am Mittwoch, 14. Dezember 2005 00:08 schrieb David Jarvie:
> I then removed the filter_actions list using the
> configure toolbars dialogue.


The problem is that this list can get removed but not added again. There has 
a report about it for a long time, but it can't be fixed in the KDE 3 
series.
Let's hope we have better possibilities in KDE 4.
Comment 4 Rodrigo S de Castro 2006-01-20 11:49:26 UTC
For me, even removing kmmainwin.rc does not work. I reinstalled the kmail package too, but no success so far. I am so used to that buffer from KDE 3.4 and previous versions, that is really annoying not having them any longer.

By checking the kmmainwin.rc, I noticed that there is an entry:

<ActionList name="toolbar_filter_actions" />

And as far as I could understand, that should be enough to these buttons to appear, right? Any other suggestion on how to get them back?
Comment 5 Andreas Gungl 2006-01-20 12:41:32 UTC
On Friday 20 January 2006 11:49, Rodrigo S de Castro wrote:
> And as far as I could understand, that should be enough to these buttons to
> appear, right? Any other suggestion on how to get them back?


You might want to check the settings for the filters in question. For example, 
look at the options to add a filter to the toolbar and what icon to be used 
for that. Try to modify the settings - does that help?
Comment 6 Rodrigo S de Castro 2006-01-24 16:12:26 UTC
I has already tried to change to other icons, but no help. I have also tried to change other options, so maybe it could trigger something to make the buttons to apper, but also no success.
Comment 7 Alan Ezust 2006-01-26 07:54:26 UTC
I also accidentally removed those toolbar actions and am in exactly the same situation. I would like to know how to bring those actions back without nuking my whole setup file from kde 3.4.
Comment 8 Alan Ezust 2006-01-26 07:56:28 UTC
oops. I should have read the full list.
Restarting without kmmainwin.rc solved it. Now I have the actions back.
Comment 9 Rodrigo S de Castro 2006-01-27 11:03:01 UTC
I tried again to remove the kmmainwin.rc and it worked (I don't why it didn't work previously). Anyway, the ActionList element I mentioned above is the one in the apply_filter_actions menu:

   <Menu name="apply_filter_actions" >
    <text>A&amp;pply Filter</text>
    <Action name="apply_filters" />
    <ActionList name="menu_filter_actions" />
   </Menu>

But in the toolbar it was missing anyway, as I found in the /usr/share/apps/kmail/kmmainwin.rc file:

  <Separator/>
  <Action name="move_to_trash" />
  <Separator/>
  <Action name="search_messages" />
  <ActionList name="toolbar_filter_actions" />

Thank you for the help, anyway. I hope we manage to find a way to add this list back when removed from the toolbar.
Comment 10 Thomas McGuire 2007-05-18 19:40:51 UTC
This seems to be a common kdelibs problem (removing actionLists from the toolbar).
Because this is not KMail specific, I close this bug.
See also bug 96209 and bug 97558.