Version: (using KDE KDE 3.5.0) Installed from: Gentoo Packages Compiler: gcc 3.4.4 OS: Linux No matter what I choose in, kcontrol -> Desktop -> Window Behaivor -> Titlebar Actions, as an titlebar wheel event, it will not work. Wheel events work nice though when used with an modifier key on inner windows, selected in Window Behaivor -> Window Actions.
Works just fine here, can you provide any additional info?
Sure, but don't know what maybe of interest. Ask about what you need an I'll do my best to answer. If you'd like to see a backtrace. You'd have to help me out here, cause I don't know how to do that actually.
this can e.g. be related to the used decoration (that could catch the wheelevent to do someting else) does it work if you use e.g. plastik? btw, you'll only get a backtrace if an app crashes - otherwise you'll have to use gdb to monitor the process
Indeed, that was it. It does not work with "B II" or "Keramik". I hope this is still a valid bug, since "Keramik" is an official window decoration, if I am not mistaken.
Created attachment 13893 [details] Adding titlebar scrollwheel support for Keramik In my opinion it's a valid bug. And both "B II" and "Keramik" are part of kdebase so I don't think it gets any more official:-) Unlike Plastik and the rest of the decorations in kdebase, those two does not use KCommonDecoration or catch the wheelevent themselves. Don't think they are suited for porting to KCommonDecoration, anyway the lack of that particular function are presumably only an oversight. Getting the functionality into Keramik was mostly copying from KCommonDecoration. The hardest part was to get a wheel mouse so I could test it:-) Since you are a Gentoo user, I guess you can simply use the patch. If it's good perhaps someone applies it to svn too.
Sweet. I just recompiled kwin with the applied patch. No errors so far. But, due to some work in progress, I cannot restart kde right now. Will test it asap though.
The patch seems to be correct. Can somebody please check all decorations in kdebase and kdeartwork and provide a patch fixing all decorations that need this change?
On Wednesday 14 December 2005 17:25, Lubos Lunak wrote: [bugs.kde.org quoted mail] I'll fix B2 as soon as possible, on the 3.5 branch, and I may look at kdeaddons later (if anyone feels like doing that sooner, please go ahead). What is the status of the trunk? I suppose Kwin decoration interface will change in KDE4, and KCommonDecoration will be folded in KDecoration, so these changes are not likely to be needed. Luciano
Your patch works here aswell. I'm compiling kdeaddons and kdeartwork right now, to see about those other decorations.
Ok, I found the following decorations: Do not work B II CDE Glow IceWM KDE 1 KStep OpenLook RISC OS Smooth Blend System++ Do work KDE 2 Laptop Modern System Plastik Quarz Redmond Web
Created attachment 13916 [details] Adding titlebar scrollwheel support for system++ Most kdeartwork styles should be ported to KCommonDecoration, making maintenance easier. But I guess it's for the KDE4 porting. Anyway I'll try to do some of the styles, starting at the bottom of the list.
Created attachment 13917 [details] Adding titlebar scrollwheel support for Smoothblend
Created attachment 13918 [details] Adding titlebar scrollwheel support for Risc OS
Created attachment 13922 [details] Adding titlebar scrollwheel support for OpenLook
Created attachment 13932 [details] Adding titlebar scrollwheel support for KStep Note: This one does not work 100% correct, as it ignores scrollwheel events over the buttons. I think fixing it would require more intrusive changes, and it's just easier to leave that to be fixed when porting to KDE4/KCommonDecoration.
Created attachment 13933 [details] Adding titlebar scrollwheel support for KStep, 2nd try Disregard the previous one, I'm obviously bot stupid and blind today:-)
Created attachment 13937 [details] Adding titlebar scrollwheel support for CDE, Glow, IceWM and KDE1 And here's the rest. Hope they all are correct.
All the patches seem correct except for the system++ one, in wheelEvent() it uses QRect( 0, 0, width(), height()), which is geometry of the complete decoration, not just the titlebar. As for the rest, since they seem to be ok, can you commit them to SVN yourself (if yes, which of trunk and 3.5?)?
Created attachment 13940 [details] Adding titlebar scrollwheel support for system++, 2nd try Oops! Yes the height() was obviously not correct, fixed in this one. I can't commit as I don't have a SVN account(safer for SVN that way:-). The patches are against 3.5. But I think all will apply to trunk too, except System(ported to new API).
I committed the patches to KDE 3.5 branch yesterday - for some reason CCBUG from the log message didn't work.
Knut: Thank you for the patches. Sandro and other decoration guys: WRT trunk, are there plans to port all clients to KCommonDecoration? Otherwise the patches should go to trunk as well.
It doesn't work with the Crystal decoration either.
Neither does it work with powder decoration. ...Keep up the good work guys! :-)