Bug 117611 - Moving tabs from terminating position can not move opposite direction
Summary: Moving tabs from terminating position can not move opposite direction
Status: RESOLVED FIXED
Alias: None
Product: konversation
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-03 19:44 UTC by Ryan Nickell
Modified: 2005-12-05 22:11 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Nickell 2005-12-03 19:44:41 UTC
Version:           Konversation: 0.19 #3041 (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc (GCC) 4.0.2 20050901 (prerelease) (SUSE Linux) 
OS:                Linux

Channel tabs in konversation are able to be moved via hotkey Alt + Ctrl + Left/Right Arrow.  This works for all tabs that are not terminating tabs(i.e. the far left or right tab).  The terminating tabs can move to the next free position, but not back to its original position.
For example, the server tab is normally the far left tab so it is a terminating tab.  Pressing the hotkey to move it right, will move it right, but while still holding the Ctrl + Alt I decide to move it back to its original position, by pressing Ctrl + Alt + Left, it won't move back.  This is true for both left and right terminating tabs.

Tabs in the middle to do not exhibit this behavior.

It feels like after a tab moves, it still keeps the property of it being a terminating tab.  It could just be that after a move, its state isn't being updated.
Comment 1 Ryan Nickell 2005-12-03 19:49:34 UTC
Btw, the hotkey I posted it wrong.  It should be Alt + Shift + Left/Right Arrow.
Comment 2 Unai Garro 2005-12-03 19:57:59 UTC
Yes, I can confirm the problem here too. It sounds as if, even if you move the tab, the edge tabs don't update their "edge/not-edge" status until you click on another tab and come back.
Comment 3 Eike Hein 2005-12-05 22:11:45 UTC
SVN commit 485833 by hein:

Update tab actions after moving a tab, so the left-most and
right-most tabs can be moved forth and back properly.
BUG:117611


 M  +2 -0      konversationmainwindow.cpp  


--- trunk/extragear/network/konversation/src/konversationmainwindow.cpp #485832:485833
@@ -2106,6 +2106,7 @@
     if(index)
     {
         getViewContainer()->moveTab(index, index - 1);
+        updateTabMoveActions(index - 1);
     }
 
     updateSwitchTabAction();
@@ -2128,6 +2129,7 @@
     if(index < (getViewContainer()->count() - 1))
     {
         getViewContainer()->moveTab(index, index + 1);
+        updateTabMoveActions(index + 1);
     }
 
     updateSwitchTabAction();