Version: (using KDE KDE 3.4.3) Installed from: Ubuntu Packages Compiler: (Tested with gcc 4.0.2 on linux) OS: Linux The attached patch adds the following features to the calendar Kipi plugin : a) The calendar cells have different width and heights in order to fill the complete page width. b) The font is bigger c) The calendar lines are printed by default. d) The unused "printCalendar" function is deleted (why was it there?). e) There is a new page in the wizard that lets you choose 2 iCalendar files. This step is purely optional. The events from the first file are going to be printed on red and the second one on green. This lets you print the official holidays (red) and your private ones (green). f) Because of e) the libkcal (kdepim) dependency has been introduced. Is it a problem? Known problems: 1. Strange looking horizontal layout print 2. This stuff needs an English native speaker
Created attachment 13618 [details] The gzipped patch.
Just a quick question from me about the inter-module dependency. Can we avoid that by copying some files from kdepim? Or does that result in the whole of kdepim? If you can create a patch without the dependency, then great, I can review it later this week and apply it to the sources.
any news?
Yes, one big news: I am still alive. :+) I have started to work on the dlopen-ed version of the patch and I hope to have something soon (not before the end of the year, however). I am sorry it takes so long.
SVN commit 540640 by toma: Draw grid by default CCBUG: 116970 M +9 -8 caltemplate.cpp --- trunk/extragear/libs/kipi-plugins/calendar/caltemplate.cpp #540639:540640 @@ -60,7 +60,7 @@ QGridLayout *mainLayout = new QGridLayout(this, 2, 1, 5, 5); // ---------------------------------------------------------------- - + QFrame *headerFrame = new QFrame( this ); headerFrame->setFrameStyle(QFrame::Panel|QFrame::Sunken); QHBoxLayout* layout = new QHBoxLayout( headerFrame ); @@ -73,17 +73,17 @@ layout->addWidget( labelTitle ); layout->setStretchFactor( labelTitle, 1 ); mainLayout->addMultiCellWidget( headerFrame, 0, 0, 0, 1 ); - + QString directory; KGlobal::dirs()->addResourceType("kipi_banner_left", KGlobal::dirs()->kde_default("data") + "kipi/data"); directory = KGlobal::dirs()->findResourceDir("kipi_banner_left", "banner_left.png"); - + pixmapLabelLeft->setPaletteBackgroundColor( QColor(201, 208, 255) ); pixmapLabelLeft->setPixmap( QPixmap( directory + "banner_left.png" ) ); labelTitle->setPaletteBackgroundColor( QColor(201, 208, 255) ); - + // ---------------------------------------------------------------- - + previewSize_ = 300; QGroupBox *boxPreview_ = new QGroupBox( i18n("Preview"), this ); @@ -147,6 +147,7 @@ checkBoxDrawLines_ = new QCheckBox(i18n("Draw lines in calendar"), gbox); gboxLayout->addWidget( checkBoxDrawLines_ ); + checkBoxDrawLines_->setChecked(true); connect(checkBoxDrawLines_, SIGNAL(toggled(bool)), SLOT(slotParamsChanged())); @@ -188,7 +189,7 @@ QFont f; comboFont_->setCurrentText( f.family() ); - + gboxLayout->addLayout( hlayout ); connect(comboFont_, SIGNAL(activated(int)), @@ -205,10 +206,10 @@ // --------------------------------------------------------------- timer_ = new QTimer(this); - + connect(timer_, SIGNAL(timeout()), SLOT(slotUpdatePreview())); - + timer_->start(0,true); }
I have modified the patch to adapt to the current HEAD. There is still a kde-pim dependency. What I propose is to put it into conditional compilation and leave the decision about enabling it to packagers.
Created attachment 19115 [details] New version of the patch The patch for the current HEAD
Alle 23:32, venerd
Will do.
Created attachment 20478 [details] Fixed patch fixed some issues, mostly calendar system ones.
Commited (together with my patch). Hope it works for others :)
I just tried to compile from svn and (as posted on digikam ML), realized the above mentioned dependency on kibkcal, i.e. on debian etch I had to do aptitude install libkcal2-dev so that the compile works fine. Should there maybe a check for libkcal2 in the configure step? Also it might be mentioned somewhere as another dependency.
Yes, there should be. Look at the first message in this bug report.
Orgad, Configure script need to be adapted to check this depency. README file must be updated too... Gilles
How do I modify the configure script?
Orgad, You don't modify the .configure script directly. Use : - configure.in.in to add new depencies rules/check - configure.in.bot to report all depencies problems/results to the console. I recommend to check how others applications witch depand of libkcal2 have implemented the configure files Gilles Caulier
Done.
I don't think it should be a strict dependency. If it doesn't exist it should compile without the special dates support. I'll work on that.
> I don't think it should be a strict dependency. > If it doesn't exist it should compile without the special dates support. > I'll work on that. Well from the point of view of a packager i need to know which packages i have to install to build all. If don't want a feature i can - patch the code/configure... - disable it if developers add an option for that. IMO if this is a good feature should be compiled by default Angelo
As a packager, I suggest that you indeed compile it.
Orgad, What's news about this file ? It still valid ? Gilles Caulier
It should be closed. The horizontal layout issue still needs to be worked on. I have it on my mind...
As the submitter, I close the bug, as my request (pushing the patch to SVN) is fulfilled. This does not mean that the system is perfect (alas!). But my knowledge of KDE and C++ is certainly too poor to make me able to do much about it...