Bug 116552 - RAR missing in Konqueror's Extract service menu
Summary: RAR missing in Konqueror's Extract service menu
Status: RESOLVED FIXED
Alias: None
Product: ark
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Harald Hvaal
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-17 10:38 UTC by Fikret Skrgic
Modified: 2010-02-11 19:55 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
patches konq-plugins/arkplugin/arkplugin.cpp (911 bytes, patch)
2005-11-18 00:30 UTC, Fikret Skrgic
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fikret Skrgic 2005-11-17 10:38:44 UTC
Version:           3.5 RC1 (using KDE KDE 3.5.0)
Installed from:    Unlisted Binary Package
Compiler:          gcc 4.0.1 
OS:                Linux

Simply, RAR is missing in Konqueror's Extract service menu. All other formats are there except RAR. Please, put it back in. This has already caused me a lot of pain, since I installed KDE 3.5 a couple of days ago. I believe that that I am not the only one whose life depends on the Extract menu. I tried to solve the problem myself. I tried to create a service menu file. I tried to use an arkservicemenus.desktop file that I found on the internet. None of that helped. I just can't get RAR into the service menu. Surprisingly, the arkservicemenus.desktop file contained entries for other formats and they work. I ended up being offered three ways of extracting for all other formats, when I right-click an archive, but none for RAR. I gave up. I have no clue where the problem might be. Since we are already talking about service menus, the menu entries "Preview in Archiver" and "Open with Ark" are just taking up space. They shouldn't be there and there is no need for them. In order to get to the useful  ones ("Extract to..", "Extract to <archive name>" and "Extract Here"), one has to go to a submenu. This should be reversed (at least). I don't remember ever clicking on "Preview in Archiver" or "Open with Ark". On the other hand, I can no longer live without "Extract Here". Why not make that (and the other two "Extract..." entries easier accesible?
Comment 1 Thiago Macieira 2005-11-17 10:51:24 UTC
This is probably related to the MIME type change.
Comment 2 Niels 2005-11-17 21:59:12 UTC
Possibly related to bug #113287.
Comment 3 Fikret Skrgic 2005-11-18 00:30:07 UTC
Created attachment 13522 [details]
patches konq-plugins/arkplugin/arkplugin.cpp

Thiago Macieira and From Niels pointed me in the right direction. Thanks, guys.
Isn't open source just fabulous? Anyway, I fixed it. It was very simple. This
patch patches konq-plugins/arkplugin/arkplugin.cpp and removes the problem.
Comment 4 Fikret Skrgic 2005-11-18 00:33:09 UTC
Sorry, Niels. I didn't pay attention and copy/pasting I copied your name as From Niels. :-)
Comment 5 Fikret Skrgic 2005-11-18 00:35:50 UTC
Resolved.
Comment 6 Henrique Pinto 2005-11-18 00:39:50 UTC
Hi!

Thank you for the patch, I'll apply it after KDE 3.5.0 is released (it seems we're on total freeze until that happens).

BTW, you should not mark bugs as resolved yourself unless you committed the fix to SVN. I'm reopening the bug, otherwise your patch would be lost.
Comment 7 Niels 2005-11-19 18:22:26 UTC
>Sorry, Niels. I didn't pay attention and copy/pasting I copied your name as From Niels. :-)

No problem, I've been called worse ;-)

Thank you for fixing this!
Comment 8 David Watzke 2005-12-15 17:27:20 UTC
Thx for fixing too. Ugly bug. :)
Comment 9 Henrique Pinto 2006-01-11 12:18:33 UTC
SVN commit 496805 by henrique:

 * Fix the right-click menu for RAR archives.
   Patch by Fikret Skrgic.
   BUG: 116552


 M  +2 -2      arkplugin.cpp  


--- branches/KDE/3.5/kdeaddons/konq-plugins/arkplugin/arkplugin.cpp #496804:496805
@@ -293,7 +293,7 @@
     }
 
     if ( !KStandardDirs::findExe( "rar" ).isNull() && m_conf->readBoolEntry( "UseRar", true ) )
-        m_archiveMimeTypes << "application/x-rar";
+        m_archiveMimeTypes << "application/x-rar" << "application/x-rar-compressed";
 
     if ( !KStandardDirs::findExe( "zoo" ).isNull() && m_conf->readBoolEntry( "UseZoo", false ) )
         m_archiveMimeTypes << "application/x-zoo";
@@ -353,7 +353,7 @@
         m_extractMimeTypes << "application/x-zip" << "application/x-jar";
 
     if ( !KStandardDirs::findExe( "unrar" ).isNull() )
-        m_extractMimeTypes << "application/x-rar";
+        m_extractMimeTypes << "application/x-rar" << "application/x-rar-compressed";
 
     if ( !KStandardDirs::findExe( "zoo" ).isNull() )
         m_extractMimeTypes << "application/x-zoo";
Comment 10 Raphael Kubo da Costa 2010-02-11 19:55:57 UTC
Changing the component to general so we can remove "Konqueror Plugin" from the component list (doesn't make sense in KDE4).