Bug 116442 - Kst settings dialog is "ridiculously wide"
Summary: Kst settings dialog is "ridiculously wide"
Status: RESOLVED INTENTIONAL
Alias: None
Product: kst
Classification: Applications
Component: general (show other bugs)
Version: 1.x
Platform: Fedora RPMs Linux
: HI normal
Target Milestone: ---
Assignee: kst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-15 20:32 UTC by Matthew Truch
Modified: 2006-04-10 20:01 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Truch 2005-11-15 20:32:03 UTC
Version:           1.2.0_svn_480257 (using KDE KDE 3.4.2)
Installed from:    Fedora RPMs
OS:                Linux

The kst settings dialog is super wide.  This seems to be because of the nearly infinite entries in the timezone selector.

Note: on some systems, the timezone selector has a drop box with a vertical scroll bar so it's width is only one column of timezones, and therefore the dialog will be of a sane (non-ridiculous) width.  On other systems, the timezone selector is a drop box without a vertical scroll bar, so it is many columns wide, which seems to drive the extreme width of the dialog box.
Comment 1 George Staikos 2005-11-15 20:49:21 UTC
  Any hint on which systems show this?
Comment 2 Matthew Truch 2005-11-15 20:57:44 UTC
> ------- Additional Comments From staikos kde org  2005-11-15 20:49 -------
>   Any hint on which systems show this?


I see the bug on my FC4 machine under kde, but another FC4 machine
(maybe not as updated, I should check) does not see it when running kst
under gnome.  Unfortunatly, I don't have any other test cases right now.
Comment 3 Matthew Truch 2005-11-15 21:10:36 UTC
>   Any hint on which systems show this?


Ok, so I lied, I don't see it on FC-3 but do see it on FC-4.

On a FC-3 machine:
[truch@pigpen ~]$ kst --version
Qt: 3.3.4
KDE: 3.4.2-0.fc3.2 Red Hat
Kst: 1.2.0_svn_478844

On FC-4:
[matt@cherry ~]$ kst --version
Qt: 3.3.4
KDE: 3.4.2-0.fc4.1 Red Hat
Kst: 1.2.0_svn_478844

The version numbers make me think that there isn't much of a difference
between the two KDE versions, but I wouldn't know.
Comment 4 George Staikos 2005-11-15 21:17:14 UTC
On Tuesday 15 November 2005 15:10, Matthew Truch wrote:
> >   Any hint on which systems show this?
>
> Ok, so I lied, I don't see it on FC-3 but do see it on FC-4.
>
> On a FC-3 machine:
> [truch pigpen ~]$ kst --version
> Qt: 3.3.4
> KDE: 3.4.2-0.fc3.2 Red Hat
> Kst: 1.2.0_svn_478844
>
> On FC-4:
> [matt cherry ~]$ kst --version
> Qt: 3.3.4
> KDE: 3.4.2-0.fc4.1 Red Hat
> Kst: 1.2.0_svn_478844


   The only possibilities are that KComboBox has changed between those, Qt is 
patched, or the timezone database has a quirk that affects the combobox 
somehow.  The timezone combo code is actually copied into our tree.

> The version numbers make me think that there isn't much of a difference
> between the two KDE versions, but I wouldn't know.


  Hard to say...
Comment 5 George Staikos 2005-11-15 22:31:48 UTC
On Tuesday 15 November 2005 14:57, Matthew Truch wrote:
> I see the bug on my FC4 machine under kde, but another FC4 machine
> (maybe not as updated, I should check) does not see it when running kst
> under gnome.  Unfortunatly, I don't have any other test cases right now.


  That's very odd.  By the way, don't forget that as of the last time I 
checked, Gnome's session manager still caused random crashes in Qt apps by 
returning invalid data.
Comment 6 Andrew Walker 2005-12-02 01:07:22 UTC
SVN commit 484808 by arwalker:

CCBUG:116442 Explicitly set fixed number of columns to try and prevent a very wide widget.

 M  +7 -0      ktimezonecombo.cpp  


--- trunk/extragear/graphics/kst/kst/ktimezonecombo.cpp #484807:484808
@@ -18,6 +18,7 @@
     Boston, MA 02110-1301, USA.
 */
 
+#include <qlistbox.h>
 #include <qmemarray.h>
 
 #include <klocale.h>
@@ -40,6 +41,12 @@
     db = new KstTimezones;
   }
 
+  if (listBox()) {
+    listBox()->setVScrollBarMode(QScrollView::AlwaysOn);
+    listBox()->setColumnMode(QListBox::FixedNumber);
+    listBox()->setRowMode(QListBox::Variable);
+  }
+  
   insertItem("UTC");
   const KstTimezones::ZoneMap zones = db->allZones();
   d->_offsets.resize(zones.count()+1);
Comment 7 Andrew Walker 2005-12-06 00:20:29 UTC
Matt, could you test on your machine to see if the code changes made any difference. Thanks.
Comment 8 Matthew Truch 2005-12-06 02:36:12 UTC
On Mon, Dec 05, 2005 at 11:20:30PM -0000, Andrew Walker wrote:
> Matt, could you test on your machine to see if the code changes made
> any difference. Thanks.


Sorry, I didn't notice the commit on Friday.

Nope, the kst settings dialog is still "ridiculously wide."  :-(
Comment 9 Andrew Walker 2006-01-26 19:47:38 UTC
Should be fixed for 1.2.1 release
Comment 10 George Staikos 2006-03-20 03:36:29 UTC
This is a bluecurve bug.
Comment 11 Matthew Truch 2006-04-10 20:01:44 UTC
George wrote:
> This is a bluecurve bug.

And it's only a bluecurve bug in FC4 (not in 3, and not in 5).  So, even I don't care any more.