Bug 116413 - Reply and Forward buttons in Yahoo Mail don't work
Summary: Reply and Forward buttons in Yahoo Mail don't work
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: khtml (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Maksim Orlovich
URL:
Keywords:
: 119277 120305 120638 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-11-15 12:21 UTC by Dan
Modified: 2006-02-09 07:18 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
patch (718 bytes, patch)
2005-11-15 16:51 UTC, Maksim Orlovich
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dan 2005-11-15 12:21:35 UTC
Version:           3.4.3-1.1.fc4.kde (Using KDE 3.4.3-1.0.fc4.kde) (using KDE KDE 3.4.3)
Installed from:    Fedora RPMs
OS:                Linux

In Yahoo Mail, a number of buttons don't work correctly.
The Reply, Forward and Mark buttons don't work at all - nothing happens when clicking on them (not even a JavaScript error icon in the bottom-right corner of the window).
Search Mail half-works (the button itself works, but the drop-down arrow beside it doesn't).

Using KDE 3.4.3 RPMs from kde-redhat on Fedora 4 (with qt-3.3.4-17.4.fc4.kde)
Comment 1 Maksim Orlovich 2005-11-15 16:51:43 UTC
Created attachment 13470 [details]
patch

Apparently they rely on getAttribute on non-existing attributes returning null
and not empty, never mind what the DOM spec says (IE and Mozilla do that,
anyway)
Comment 2 Maksim Orlovich 2005-11-15 17:07:53 UTC
Of course, as expected, this lights up like crazy in DOM tests, including one of the standard ones
Comment 3 Michael Gorbach 2005-11-17 15:13:46 UTC
I can confirm this using kde3.5 rc1.
This will be fixed i hope?
Also ... I think the javascript showing suggested email addresses does not work either.
Comment 4 Maksim Orlovich 2005-11-17 17:00:32 UTC
Too late for 3.5, I am afraid, but should be in 3.5.1... where is the suggested e-mail addresses thing?
Comment 5 Michael Gorbach 2005-11-17 19:07:30 UTC
when you type an email address in the to field, if it matches something youve used earlier or its in your book, it will show a dropdown and offer to fill it in. This doesn't happen in konq.
Comment 6 Pablo De Napoli 2005-11-19 20:09:02 UTC
I also can confirm it (using kde_3.5.0_rc1)
I'll find it useful if you could fix this bug!
Comment 7 Pablo De Napoli 2005-11-20 21:33:51 UTC
I can confirm that the patch by  Maksim Orlovich (comment #1)
works for kde_3.5.0_rc1
Comment 8 Maksim Orlovich 2005-11-22 05:13:25 UTC
That suggestion thing seems to go along with the rich-text composer, while we get the plain one; we can't handle the complex ATM, and it is hardly a trivial thing to support (falls under a major project of one of the contributors..)
Comment 9 Michael Gorbach 2005-11-28 04:34:17 UTC
Maskim, thanks for fixing the button-not-working issue.
What would be needed to support the richtext composer?
Comment 10 Maksim Orlovich 2005-12-07 05:21:30 UTC
SVN commit 486217 by orlovich:

Match mozilla + Safari, and return null on getAttribute 
when it's not there. Fixes yahoomail and an unknown number of other sites.
BUG:116413


 M  +4 -1      kjs_dom.cpp  


--- branches/KDE/3.5/kdelibs/khtml/ecma/kjs_dom.cpp #486216:486217
@@ -1088,7 +1088,10 @@
 
   switch(id) {
     case DOMElement::GetAttribute:
-      return String(element.getAttribute(args[0].toString(exec).string()));
+      /** In theory, we should not return null here, as per DOM. In practice, that 
+       breaks websites
+      */
+      return getString(element.getAttribute(args[0].toString(exec).string()));
     case DOMElement::SetAttribute:
       element.setAttribute(args[0].toString(exec).string(),args[1].toString(exec).string());
       return Undefined();
Comment 11 Maksim Orlovich 2005-12-07 05:25:08 UTC
As for the richtext composer: not sure, likely a huge amount of work
Comment 12 Maksim Orlovich 2005-12-31 04:04:29 UTC
*** Bug 119277 has been marked as a duplicate of this bug. ***
Comment 13 Tommi Tervo 2006-01-17 14:09:26 UTC
*** Bug 120305 has been marked as a duplicate of this bug. ***
Comment 14 Tommi Tervo 2006-01-23 09:53:08 UTC
*** Bug 120638 has been marked as a duplicate of this bug. ***
Comment 15 Kanwar Plaha 2006-01-24 02:12:59 UTC
Hi,
I am using KDE 3.5 and am still hitting this bug. Since I use binary packages, how do I apply the patch, if any?

Thanks.
Comment 16 tgpfx 2006-01-24 10:51:34 UTC
I don't think that there is a patch out for it yet, so
I have switched to Firefox for dealing with Yahoo
emails.
--- Kanwar Plaha <Kanwar.Plaha@gmail.com> wrote:

[bugs.kde.org quoted mail]



		
___________________________________________________________ 
To help you stay safe and secure online, we've developed the all new Yahoo! Security Centre. http://uk.security.yahoo.com
Comment 17 Maksim Orlovich 2006-01-25 15:03:24 UTC
There is way of applying a source patch to binary packages -- you have to compile a new version. The easiest may be to wait a couple more days for 3.5.1 to be out.
Comment 18 Maksim Orlovich 2006-01-25 15:05:32 UTC
There is -NO- way, that is.
Comment 19 semovrs 2006-02-09 07:18:47 UTC
For a long-term solution scrap yahoo mail altogether for gmail. I've had yahoo for five years now and I am slowly shifting to gmail. gmail's got it all - POP3, web access, smtp, huge mailbox, on top of that everything is secure, over SSL. I am tired of getting invalid certificate popup any time I call https://mail.yahoo.com. I can't believe yahoo can't pay $100/year to buy one, it's just ridiculous.