Bug 116387 - kprinter corrupts output colour if OKing printer driver settings
Summary: kprinter corrupts output colour if OKing printer driver settings
Status: RESOLVED UNMAINTAINED
Alias: None
Product: kdeprint
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: KDEPrint Devel Mailinglist
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-15 00:36 UTC by Fred Labrosse
Modified: 2011-05-27 18:10 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
IPP report of a working job (10.09 KB, application/pdf)
2005-11-15 00:40 UTC, Fred Labrosse
Details
IPP report of a job that does not print correctly (9.81 KB, application/pdf)
2005-11-15 00:42 UTC, Fred Labrosse
Details
The PPD file (88.79 KB, text/plain)
2005-11-15 17:16 UTC, Fred Labrosse
Details
The lpoptions file (65 bytes, text/plain)
2005-11-15 17:17 UTC, Fred Labrosse
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fred Labrosse 2005-11-15 00:36:59 UTC
Version:            (using KDE KDE 3.4.1)
Installed from:    Gentoo Packages
OS:                Linux

When printing a document with kprinter, if I don't change the driver settings, all prints fine.  If I open the window allowing me to change these settings and close it with "Cancel", all prints fine.  If I close that same window with "OK" *without* changing anything, then the printout colours are wrong.  The IPP reports for the two jobs are actually different, at list in the fact that the one that works does include the profile I normally use (from /etc/cups/lpoptions) and the one that does not work does not include the profile (IPP reports attached).
Comment 1 Fred Labrosse 2005-11-15 00:40:18 UTC
Created attachment 13457 [details]
IPP report of a working job

This is the IPP report of the job when it prints correctly.  Note the inclusion
of the profile attribute.
Comment 2 Fred Labrosse 2005-11-15 00:42:03 UTC
Created attachment 13458 [details]
IPP report of a job that does not print correctly

This is the IPP report of the printing job of the same file as the previous
job, this one not printing correctly (wrong colours).  Note the lack of
"profile" atribute.
Comment 3 Michael Goffioul 2005-11-15 08:59:18 UTC
Could you post the PPD file for your printer, as well as the relevant lpoptions file. Usually, when a print option has the default value, it is not added to the print option set (which seems reasonable).

Michael.
Comment 4 Fred Labrosse 2005-11-15 10:55:00 UTC
Will post the PPD and lpoptions files when back at home.  It does make sense not to include default values but given the difference in printout, the profile is not made of default values (especially given that it is included in one of the cases).

I've thought a bit more about that and came to the conclusion that maybe it makes sense not to use the options in lpoptions when one changes options in kprinter given that presumably the options could have been overwritten.  However, many options available from kprinter are not in the profile.  So maybe a solution would be to integrate the profile options into the kprinter dialog by modifying the relevant values, if you see what I mean.

BTW, the profile option in /etc/cups/lpoptions was generated by cups-calibrate.
Comment 5 Fred Labrosse 2005-11-15 17:16:16 UTC
Created attachment 13471 [details]
The PPD file

The PPD file of the printer.
Comment 6 Fred Labrosse 2005-11-15 17:17:18 UTC
Created attachment 13472 [details]
The lpoptions file

The /etc/cups/lpoptions file, created by cups-calibrate.
Comment 7 Michael Goffioul 2005-11-16 09:18:01 UTC
Talking about options not being added when equal to default value, this only applies to driver options (those found in the PPD file), which "profile" is not. So there's probably a problem, the "profile" option being lost when opening the printer properties dialog.

For Cristian: looking at how I implemented it, I assumed that the properties dialog would recreate *all* print options. If you look at KPrinterPropertiesDialog::setupPrinter(), you see that the print options set is recreated from scratch. This means that if some print option is not handled by some property page, it's lost. I think some merging should occur at this point,
by making use of the m_options data member (which should contain the complete set of updated print options). I don't remember why I didn't do it that way, maybe there are some side-effects I don't remember.

Michael.
Comment 8 Fred Labrosse 2005-11-16 10:15:39 UTC
But surely the profile refers to values for the options in the PPD file (just wondering as I haven't looked in detail at what is put in the profile).
Comment 9 Michael Goffioul 2005-11-16 10:22:51 UTC
Probably yes, but there's no "profile" option defined in the PPD file and the way how these relates to the actual print options in the PPD file is most probably highly Gutenprint-dependent, maybe subject to changes, and I wouldn't rely on it. The problem you have is that the "profile" option gets forgotten by kdeprint when the printer properties dialog is opened and closed, this shouldn't happen.

Michael.
Comment 10 John Layt 2011-05-27 18:10:31 UTC
KDEPrint is obsolete, unmaintained and will never be revived.  Closing all open bugs.