Bug 113953 - Solaris keytab name has trailing quote character
Summary: Solaris keytab name has trailing quote character
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: 1.5
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-06 10:45 UTC by Jonathan Wakely
Modified: 2005-10-06 19:14 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot showing bug (20.41 KB, image/png)
2005-10-06 10:46 UTC, Jonathan Wakely
Details
Patch for solaris.keytab (289 bytes, patch)
2005-10-06 10:47 UTC, Jonathan Wakely
Details
Fix spelling mistake in error message (460 bytes, patch)
2005-10-06 13:23 UTC, Jonathan Wakely
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Wakely 2005-10-06 10:45:47 UTC
Version:           1.5 (using KDE KDE 3.4.0)
Installed from:    SuSE RPMs
Compiler:          N/A N/A
OS:                Linux

Settings->Configure Konsole->Session

In the Keytab dropdown, Solaris is shown with a trailing quote character (see attached image).

This appears to be because solaris.keytab has a trailing space character on this line:

keyboard "Solaris" 
                  ^ trailing space character

I haven't checked the code but it seems that the code to parse the keytab file just assumes that the last character on the line is the closing quote, and just removes the last character. That is a bit poor, but the problem can be avoided by removing the trailing space.
Comment 1 Jonathan Wakely 2005-10-06 10:46:25 UTC
Created attachment 12887 [details]
Screenshot showing bug
Comment 2 Jonathan Wakely 2005-10-06 10:47:31 UTC
Created attachment 12888 [details]
Patch for solaris.keytab

This patch removes the trailing space from the keytab file.
Comment 3 Jonathan Wakely 2005-10-06 13:23:15 UTC
Created attachment 12892 [details]
Fix spelling mistake in error message

This patch is unrelated to this bug, it just fixes a typo (multible) in an
error message in konsole's keytrans.cpp.  Not worth filing a new bug though, so
I've attached it here.
Comment 4 Kurt Hindenburg 2005-10-06 19:14:50 UTC
SVN commit 467880 by hindenburg:

Fix solaris.keytab space/quote; spelling error.

I don't see the extra " as the screenshot displays.

BUG: 113953


 M  +1 -1      konsole/keytrans.cpp  
 M  +1 -1      other/solaris.keytab  


--- branches/KDE/3.5/kdebase/konsole/konsole/keytrans.cpp #467879:467880
@@ -405,7 +405,7 @@
       ptrdiff_t bits = (ptrdiff_t)(syms->modsyms[res]) - 1;
       if (mask & (1 << bits))
       {
-        fprintf(stderr,"%s(%d,%d): mode name used multible times.\n",path.ascii(),slinno,scolno);
+        fprintf(stderr,"%s(%d,%d): mode name used multiple times.\n",path.ascii(),slinno,scolno);
       }
       else
       {
--- branches/KDE/3.5/kdebase/konsole/other/solaris.keytab #467879:467880
@@ -1,7 +1,7 @@
 # [solaris.keytab] Konsole Keyboard Table 
 # 
 
-keyboard "Solaris" 
+keyboard "Solaris"
 
 # --------------------------------------------------------------
 #