Version: 1.3-SVN (using KDE 3.3.0, SuSE) Compiler: gcc version 3.2.2 OS: Linux (i586) release 2.4.19-4GB Start amaroK, compose a playlist with more than 1500 entries. Click on a playlist column to sort the playlist, e.g. "Filename", this one works reliably. Exit amaroK, then start it again -> crash. Only way to get it working is rm current.xml.
Created attachment 12653 [details] Backtrace
SVN commit 462932 by markey: FIX: amaroK could crash on startup, if on last exit sorting was enabled in the playlist. The problem was that KListView::restoreLayout() also restores the sort order. Then, with sorting enabled, we restored current.xml. Qt obviously did not find this funny. BUG: 113042 M +2 -0 ChangeLog M +4 -1 src/playlist.cpp --- trunk/extragear/multimedia/amarok/ChangeLog #462931:462932 @@ -15,6 +15,8 @@ by dragging it. Patch by Eyal Lotem <eyal.lotem@gmail.com>. (BR 103990) BUGFIXES: + * amaroK could crash on startup, if on last exit sorting was enabled in + the playlist. (BR 113042) * Adding entries to a playlist and saving it could duplicate some tracks, if the playlist hadn't been expanded before. (BR 111579) --- trunk/extragear/multimedia/amarok/src/playlist.cpp #462931:462932 @@ -214,7 +214,6 @@ setDropVisualizer( false ); //we handle the drawing for ourselves setDropVisualizerWidth( 3 ); setItemsRenameable( true ); - KListView::setSorting( NO_SORT ); //use base so we don't saveUndoState() too setAcceptDrops( true ); setSelectionMode( QListView::Extended ); setAllColumnsShowFocus( true ); @@ -304,6 +303,10 @@ engineStateChanged( EngineController::engine()->state() ); //initialise state of UI paletteChange( palette() ); //sets up glowColors restoreLayout( KGlobal::config(), "PlaylistColumnsLayout" ); + + // Sorting must be disabled when current.xml is being loaded. See BUG 113042 + KListView::setSorting( NO_SORT ); //use base so we don't saveUndoState() too + columnOrderChanged(); //cause the column fractions to be updated, but in a safe way, ie no specific column columnResizeEvent( header()->count(), 0, 0 );
Created attachment 12841 [details] fix