Bug 112751 - kst freezes when clear is pressed in debug dialog
Summary: kst freezes when clear is pressed in debug dialog
Status: RESOLVED FIXED
Alias: None
Product: kst
Classification: Applications
Component: general (show other bugs)
Version: 1.x
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: kst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-16 19:05 UTC by Matthew Truch
Modified: 2005-09-16 19:15 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Truch 2005-09-16 19:05:08 UTC 
Version:           1.2.0_svn_460893 (using KDE KDE 3.4.1)
Installed from:    Fedora RPMs
OS:                Linux

kst freezes when the clear button in the log tab of the debug kst dialog is pressed.

How to reproduce:  Open kst.  No need to plot any data.  Open the debug dialog, go to the log, press clear.

Expected behavior:  kst doesn't freeze.  I'd assume something like clearing the log would also happen, but I'm more concerned with kst not freezing.  ;-)

Note:  By freeze I do not mean crash (with a signal), nor do I mean some issue where kst is consuming all the CPU.
Comment 1 George Staikos 2005-09-16 19:15:04 UTC 
SVN commit 461163 by staikos:

This lock isn't recursive, so acquire it only once

BUG: 112751


 M  +1 -1      kstdebug.cpp  


--- trunk/extragear/graphics/kst/kst/kstdebug.cpp #461162:461163
@@ -107,11 +107,11 @@
 
 
 void KstDebug::clear() {
+  clearHasNewError(); // has to be before the lock is acquired
   QMutexLocker ml(&_lock);
   _messages.clear(); 
   LogEvent *e = new LogEvent(LogEvent::LogCleared);
   QApplication::postEvent(_handler, e);
-  clearHasNewError();
 }