Bug 111661 - CTCP VERSION reply on svn is broken
Summary: CTCP VERSION reply on svn is broken
Status: RESOLVED FIXED
Alias: None
Product: konversation
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR crash
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-28 18:56 UTC by Harald Sitter
Modified: 2005-08-28 20:40 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2005-08-28 18:56:44 UTC 
Version:           0.19 #3031 (using KDE KDE 3.4.2)
Installed from:    SuSE RPMs
Compiler:          gcc version 3.3.5 20050117 (prerelease) (SUSE Linux)
OS:                Linux (i686) release 2.6.11.4-21.8-default

If someone does a ctcp version sending on me, konvi opens a query with something like this:
  [2005-08-28 18:40:55] <socke> VERSION 

I tested this with some people which are also on svn, same thing with them.

Actually I dunno where the problem is, so, happy searching ;-)
Comment 1 Harald Sitter 2005-08-28 20:40:41 UTC 
SVN commit 454369 by psn:

Ok another try to fix CTCP hopefully I don't break something else this 
time...


 M  +1 -1      inputfilter.cpp  


--- trunk/extragear/network/konversation/src/inputfilter.cpp #454368:454369
@@ -128,7 +128,7 @@
     {
         bool isChan = isAChannel(parameterList[0]);
         // CTCP message?
-        if(server->identifyMsg() && (trailing.at(1) != QChar(0x01) || \
trailing.lower().contains(0x01 + "action"))) { +        if(server->identifyMsg() && \
(trailing.at(0) == '+' || trailing.at(0) == '-')) {  trailing = trailing.mid(1);
         }