Bug 109693 - Konsole bookmark incompatibility with mc
Summary: Konsole bookmark incompatibility with mc
Status: RESOLVED NOT A BUG
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: 1.5
Platform: Debian stable Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-27 09:53 UTC by Gang Xiao
Modified: 2006-01-06 16:54 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Kdelibs-patch (637 bytes, patch)
2005-07-28 20:19 UTC, Alexander Rigbo
Details
New shellQuote patch that works (911 bytes, patch)
2005-07-30 16:37 UTC, Alexander Rigbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gang Xiao 2005-07-27 09:53:21 UTC
Version:           1.5 (using KDE KDE 3.4.0)
Installed from:    Debian stable Packages

Konsole local file bookmark with quotes does not work with mc who doesn't know dequoting.

Suggestion: add quotes to directories only when necessary (e.g. when the directory name has embedded spaces).
Comment 1 Alexander Rigbo 2005-07-28 11:53:17 UTC
You're asking for a change in KRun::shellQuote.

If this bug gets confirmed I can probably fix this.
Comment 2 Alexander Rigbo 2005-07-28 20:19:47 UTC
Created attachment 11972 [details]
Kdelibs-patch

I rewrote the shellquote function a little.
This is the first QT i've ever written :)
Comment 3 Alexander Rigbo 2005-07-30 16:37:09 UTC
Created attachment 12000 [details]
New shellQuote patch that works

It seems that the old patch didn't quite work.
Here's a new one.
Comment 4 Kurt Hindenburg 2005-07-30 17:46:12 UTC
That patch is for kdelibs; you need to send the patch to the kde-core-devel mailing list for approval.
I haven't tested it yet...
Comment 5 Kurt Hindenburg 2006-01-06 16:54:17 UTC
Not Konsole related.