Bug 109689 - large green LED appears in kbinaryclock (dupe of 96541 but still not fixed despite being marked resolved)
Summary: large green LED appears in kbinaryclock (dupe of 96541 but still not fixed de...
Status: RESOLVED FIXED
Alias: None
Product: kicker
Classification: Plasma
Component: kbinaryclock (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Aaron J. Seigo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-27 06:50 UTC by Triffid Hunter
Modified: 2005-10-30 23:09 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
as seen upon kicker startup (5.01 KB, image/png)
2005-07-27 07:21 UTC, Triffid Hunter
Details
after changing any option and applying (4.54 KB, image/png)
2005-07-27 07:22 UTC, Triffid Hunter
Details
Proposed Patch (376 bytes, patch)
2005-08-11 15:37 UTC, Sascha Hlusiak
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Triffid Hunter 2005-07-27 06:50:19 UTC
Version:            (using KDE KDE 3.4.1)
Installed from:    Gentoo Packages
Compiler:          gcc 3.4 
OS:                Linux

I had this problem in kde 3.3 as well as my current 3.4.1

gentoo bug: 
http://bugs.gentoo.org/show_bug.cgi?id=100312 

screenshots: 
http://funkmunch.net/~triffid/kbinaryclock/


it seems the other bug was marked resolved because a single developer couldn't reproduce it, and there's no 'reopen bug' button anywhere that I can see...
Comment 1 Aaron J. Seigo 2005-07-27 07:12:58 UTC
please upload screenshots as attachments to this bug report.

and for the record, i can't reproduce this either.
Comment 2 Triffid Hunter 2005-07-27 07:21:17 UTC
Created attachment 11948 [details]
as seen upon kicker startup
Comment 3 Triffid Hunter 2005-07-27 07:22:03 UTC
Created attachment 11949 [details]
after changing any option and applying
Comment 4 Triffid Hunter 2005-07-27 07:24:27 UTC
both attachments have the areas surrounding the clock "dimmed" for clarity.

note that the "com" visible in the background is due to my desktop background + transparent panel, and isn't related to the clock or this bug report.
Comment 5 Sascha Hlusiak 2005-08-11 15:37:10 UTC
Created attachment 12175 [details]
Proposed Patch

Problem only occurs, when you do not show the seconds of the clock, while the
applet is starting. The 8 additional kleds for the seconds are not hidden
properly. 

Patch should fix this.
Comment 6 Aaron J. Seigo 2005-10-30 23:09:56 UTC
SVN commit 475887 by aseigo:

hide the seconds leds properly.
patch by Sascha Hlusiak
BUG:109689


 M  +1 -1      kbinaryclock.cpp  


--- branches/KDE/3.5/kdeaddons/kicker-applets/kbinaryclock/kbinaryclock.cpp #475886:475887
@@ -188,7 +188,7 @@
 	bool showSeconds = prefs->show_Seconds();
 	ledWidth = (showSeconds == true) ? 6 : 4;
 	for(int i=0; i < 4; i++){
-		for(int j=4; j < ledWidth;j++){
+		for(int j=4; j < 6;j++){
 			if(showSeconds)
 				ledMatrix[j][i]->show();
 			else