Bug 109276 - Regression: Recent cover manager changes introduced completely broken behavior
Summary: Regression: Recent cover manager changes introduced completely broken behavior
Status: RESOLVED NOT A BUG
Alias: None
Product: juk
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Scott Wheeler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-18 21:38 UTC by Thomas McGuire
Modified: 2005-10-04 04:35 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas McGuire 2005-07-18 21:38:34 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:                Linux

The recent changes to the cover manager made it unusable for me, basically because 1 album == 1 cover is no longer true.
Reasons:

1. 
Downloading a cover for an album no longer works as expected.
Let's say I have an album which contains 10 songs.
Previously, I was able to select one of those songs, use "RMB->Cover Manager->Get Cover from Internet", select the proper cover and was done with it. All songs from that album now had the correct cover set, which additionally was only stored once on disk.

Now, if I try the same, only the selected song gets the cover assigned. The other songs from the same album remained without any cover.
This behavior alone is annoying, but it gets worse:
After selecting all songs from that album and then downloading the correct cover, only the first song of the selected 10 songs gets the cover assigned.

This means I know have to invoke the cover downloader 10 times in order to assign the correct cover to all songs. Previously I was done with using it once.

2. 
The above behavior also means the covers take up much more disk space. Let's say the average album contains 10 songs, then 10 times more disk space is used now. It is simply unacceptable big, my  cover directory is now 55 MB instead of 30 MB. The many duplicates are not nessacarry.

3.
The newly introduced "Show cover manager" dialog also suffers from the duplicate covers.
Instead of showing one cover per album for every artist, it shows one cover per song for every artist. This is not usefull.

----

4.
Why is there an OK button in the cover from internet download dialog ?
The cover is immediately downloaded when clicked onto, there seems to be no need for the OK button.

5.
I know this is unrelated to the recent changes, but when I remove 1 cover, I get this question:
"Are you sure you want to delete these covers?"
In this case, "these covers" should be "this cover".
Comment 1 Thomas McGuire 2005-07-19 16:16:28 UTC
On Monday 18 July 2005 21:38, Thomas McGuire wrote:
> 1.
> Downloading a cover for an album no longer works as expected.
> Let's say I have an album which contains 10 songs.
> Previously, I was able to select one of those songs, use "RMB->Cover
> Manager->Get Cover from Internet", select the proper cover and was done
> with it. All songs from that album now had the correct cover set, which
> additionally was only stored once on disk.
>
> Now, if I try the same, only the selected song gets the cover assigned. The
> other songs from the same album remained without any cover. This behavior
> alone is annoying, but it gets worse:
> After selecting all songs from that album and then downloading the correct
> cover, only the first song of the selected 10 songs gets the cover
> assigned.
>
> This means I know have to invoke the cover downloader 10 times in order to
> assign the correct cover to all songs. Previously I was done with using it
> once.

Small correction: I now noticed that the old behavior is indeed there - but 
only after a restart of Juk. This also seems to solve to duplication problem, 
the cover manager only shows these covers once.
So, what now happens is:
After selecting a song and downloading the cover for its album, only that 
songs gets the cover assigned. After restarting Juk, all other songs from the 
same album now also have the same cover assigned, like expected. 
The restart should not be necessary, all songs from the same album should get 
the cover assigned immediately.
Comment 2 Michael Pyne 2005-10-04 04:35:46 UTC
> Small correction: I now noticed that the old behavior is indeed there -
> but only after a restart of Juk. This also seems to solve to duplication
> problem, the cover manager only shows these covers once.

Well as of a few weeks ago, the cover manager won't automatically apply album covers even to tracks with a matching Album and Artist.  This is because the cover manager has no way to tell whether a track has no cover because the user hasn't found one, or because the user doesn't want one (i.e. he used Remove Cover on the track).

The behavior you're describing as a regression was a side effect of the way covers were stored in KDE 3.4, where covers were always tied to the Album and Artist of a track so tracks that happened to have matching data got the cover "for free".

The covers can be assigned independently of Artist and Album which means that behavior no longer happens for free (and indeed, shouldn't always happen).  There is a way to easily set covers for a whole album though.  Just select all the tracks first.  Don't think of it as a hack either. :)  This also allows you to set the same cover for 2 disc sets if you're insane like me and tag tracks down to the disc for multiple disc albums.  With JuK 3.4 you would have had 2 or more separate copies of the same cover art.

Note that when starting up JuK 3.5 for the first time, it should automatically import your JuK 3.4 covers and automatically assign covers to your tracks as they would have been set in 3.4.  After that, however, the cover a track has is completely up to you.

If you want to quickly re-use a cover for a different track or set of tracks, you can either use the Cover Manager (which is admittedly not that spectacular) and drag a cover from there, or drag the cover from the Now Playing bar.  Either way, just drop the cover onto a track or a group of selected tracks and they will quickly have their cover changed.

So, the cover manager is a bit different, but I think it's an improvement.  I may introduce a different state in KDE 4.0 to represent tracks with a "never set" cover that could be automatically filled in when possible for it's too late for that in KDE 3.5.