Bug 109188 - Data CD Project User Defaults Settings > Multisession Mode not retrieved
Summary: Data CD Project User Defaults Settings > Multisession Mode not retrieved
Status: RESOLVED FIXED
Alias: None
Product: k3b
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Sebastian Trueg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-17 00:24 UTC by D.L.C.Burggraaff
Modified: 2005-07-18 21:58 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description D.L.C.Burggraaff 2005-07-17 00:24:01 UTC
Version:           0.12.2 (using KDE 3.4.1, compiled sources)
Compiler:          gcc version 3.3.4
OS:                Linux (i686) release 2.6.10

When initializing a new Data CD Project the User Defaults are used but for the Settings > Multisession Mode which is consistantly set to "Auto". First when I press the User Defaults button my "No Multisession" setting is retrieved.

One could argue (mistakenly in my opinion) that the "Start Multisession" and "Finish Multisession" options have a one-off feel and therefore should not be kept/retrieved for a next project, but that is certainly not the case for the "No Multisession" option.

I would say that this is a continuation of bug 75785 "Usability: Improve session handling in burn dialog"
Comment 1 Sebastian Trueg 2005-07-17 21:16:14 UTC
SVN commit 435652 by trueg:

Properly load default multisession settings.

BUG: 109188


 M  +2 -0      ChangeLog  
 M  +7 -6      libk3b/tools/k3biso9660.cpp  
 M  +12 -0     src/k3bprojectmanager.cpp  


--- branches/stable/extragear/multimedia/k3b/ChangeLog #435651:435652
@@ -1,6 +1,8 @@
 0.12.3
 ======
+ * Ignore dock config from K3b versions older than 0.12
  * Do not delete DVD project iso image if "remove image" is unchecked.
+ * Properly load multisession default settings.
 
 0.12.2
 ======
--- branches/stable/extragear/multimedia/k3b/libk3b/tools/k3biso9660.cpp #435651:435652
@@ -579,6 +579,13 @@
 	dirent = new K3bIso9660Directory( this, path, access | S_IFDIR,
 					  buf.st_mtime, buf.st_atime, buf.st_ctime, uid, gid, QString::null );
 
+	level=0;
+	mycallb( idr, this );
+	if (m_joliet)
+	  c_j++;
+	else
+	  c_i++;
+
 	if( m_joliet )
 	  d->jolietDirs.append( dirent );
 	else {
@@ -587,12 +594,6 @@
 	  d->isoDirs.append( dirent );
 	}
 
-	level=0;
-	mycallb( idr, this );
-	if (m_joliet)
-	  c_j++;
-	else
-	  c_i++;
 	break;
       }
     }
--- branches/stable/extragear/multimedia/k3b/src/k3bprojectmanager.cpp #435651:435652
@@ -345,6 +345,18 @@
     
     dataDoc->setVerifyData( c->readBoolEntry( "verify data", false ) );
 
+    QString s = c->readEntry( "multisession mode" );
+    if( s == "none" )
+      dataDoc->setMultiSessionMode( K3bDataDoc::NONE );
+    else if( s == "start" )
+      dataDoc->setMultiSessionMode( K3bDataDoc::START );
+    else if( s == "continue" )
+      dataDoc->setMultiSessionMode( K3bDataDoc::CONTINUE );
+    else if( s == "finish" )
+      dataDoc->setMultiSessionMode( K3bDataDoc::FINISH );
+    else
+      dataDoc->setMultiSessionMode( K3bDataDoc::AUTO );
+
     break;
   }
 
Comment 2 D.L.C.Burggraaff 2005-07-18 21:58:14 UTC
Dear Sebastian,
Thank you for your quick response.
The k3bprojectmanager.cpp fix indeed resolved the problem.
Kind regards, Dick