Bug 108458 - Make gives error "digikamthumbnail.cpp:662: error: visibility arg must be one of "default", "hidden", "protected" or "internal"
Summary: Make gives error "digikamthumbnail.cpp:662: error: visibility arg must be one...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Portability-Compilation (show other bugs)
Version: 0.7.3
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-03 00:25 UTC by Stephan van den Akker
Modified: 2017-08-19 21:10 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan van den Akker 2005-07-03 00:25:38 UTC
Version:           0.7.3 (using KDE KDE 3.3.0)
Installed from:    SuSE RPMs
Compiler:          gcc 3.3.4 
OS:                Linux

Performed all the steps in README. configure doesn't produce any error messages, but the make process stops with the following messages:

digikamthumbnail.cpp:662: error: visibility arg must be one of "default",
   "hidden", "protected" or "internal"
make[3]: *** [digikamthumbnail.lo] Error 1
make[3]: Leaving directory `/home/stephan/Software/digikam/digikam-0.7.3/digikam/kioslave'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/stephan/Software/digikam/digikam-0.7.3/digikam'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/stephan/Software/digikam/digikam-0.7.3'
make: *** [all] Error 2

this is preceded by multiple warnings during make. Examples:
In file included from imagepropertieshistogram.cpp:44:
../../digikam/libs/histogram/imagehistogram.h:110: warning: `visibility'
   attribute does not apply to types
In file included from imagepropertieshistogram.cpp:45:
../../digikam/libs/widgets/histogramwidget.h:162: warning: `visibility'
   attribute does not apply to types
In file included from imagepropertieshistogram.cpp:46:
../../digikam/libs/widgets/colorgradientwidget.h:44: warning: `visibility'
   attribute does not apply to types
In file included from digikamfirstrun.cpp:62:
digikamfirstrun.h:51: warning: `visibility' attribute does not apply to types
In file included from main.cpp:57:
digikamapp.h:215: warning: `visibility' attribute does not apply to types
In file included from main.cpp:58:
digikamfirstrun.h:51: warning: `visibility' attribute does not apply to types
Comment 1 Thiago Macieira 2005-07-03 00:31:29 UTC
Upgrade KDE to >= 3.3.1.
Comment 2 Stephan van den Akker 2005-07-03 01:23:11 UTC
This doesn't solve my problem.

the "dependency" part of both the kde extragear/digikam website and the README file clearly state a the need for "KDE 3.x", not "KDE >=3.3.1". It should be possible to find a less drastic solution.

I simply can't afford to mess around with my system the way you propose. Swapping out KDE is a big deal for an average user like me. Generally speaking, upgrades like these should not be necessary on a perfectly working system that is less than 1 year old.
Comment 3 Stephan van den Akker 2005-07-03 01:34:04 UTC
This doesn't solve my problem.

the "dependency" part of both the kde extragear/digikam website and the README file clearly state a the need for "KDE 3.x", not "KDE >=3.3.1". It should be possible to find a less drastic solution.

I simply can't afford to mess around with my system the way you propose. Swapping out KDE is a big deal for an average user like me. Generally speaking, upgrades like these should not be necessary on a perfectly working system that is less than 1 year old. 		
Comment 4 Thiago Macieira 2005-07-03 01:40:41 UTC
The fix is in KDE 3.3.1. Your two options are:

1) update to KDE 3.3.1 or better; or downgrade to KDE 3.2.3 or lower
or
2) don't use a compiler that supports -fvisibility

If you use a compiler with -fvisibility, you CANNOT use KDE 3.3.0. You can use other versions.
Comment 5 Vardhman 2005-07-03 07:52:06 UTC
On 2 Jul 2005 23:40:42 -0000, Thiago Macieira <thiago@kde.org> wrote:
[bugs.kde.org quoted mail]
Both these options are more drastic compared making the user simply
modify the kdemacros.h file to rectify the error in definition of 
visibility attributes. Should that be give  as an option too?
A simply change of value from "visibile" to "default" in Kde macros.h
seems to be a perfect solution to me, is there any hidden problem with
such a solution?
AFAIK Fedora Core 3 gives KDE3.3.0-5 and FC3 must be a large user
base, we can't ask all such users to do some small hacking, we need to
do ourself or release a RPM package with the required patch.

Just a suggestion.
Vardhman

PS: I have faced this problem and it really took lot of time to
understand what the problem was. Finally I compiled the code by
switching off the Visibilty stuff throught the configure.in.in files.
Comment 6 Stephan van den Akker 2005-07-03 11:05:04 UTC
Thanks for your suggestion, Vardman!

This got rid of the show-stopping bug for me! Now I am happily browsing my digital photo collection with version 0.7.3. (The compiler warnings I mentioned are still there though).

You mentioned RPM-packages. SuSE does tend to supply fairly up-to-date ones, but they depend heavily on the accompanying "bleeding edge" KDE-packages. I have mixed experiences with those, so I don't want to install them on "production" systems.

Greetings, and many thanks!
Comment 7 Felix 2005-07-10 05:46:49 UTC
just to note, I am running KDE 3.3.1 on FC3 and the problem exists. Modifying kdemacros.h resolved the problem; but upgrading KDE doesn't