Bug 108107 - Ignore end word @ when selecting symbolic links with mouse double click
Summary: Ignore end word @ when selecting symbolic links with mouse double click
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-25 12:24 UTC by Albert Astals Cid
Modified: 2005-07-08 22:13 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Albert Astals Cid 2005-06-25 12:24:48 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:                Linux

When trying to copy symbolic links (that have an @ at the end so that you know they're a symbolic link) i double click on them and get the @ selected too, this does not happens with executables (that have an * at the end so that you know they're a executable)

It would be nice if @ was not selected.
Comment 1 Kurt Hindenburg 2005-06-26 01:09:41 UTC
Go to Settings->Configure Konsole;  at the bottom of the General tab you'll see 'Double click'; remove the @ from the text box. 
I think that the @ is there to pick up email addresses....
Comment 2 Albert Astals Cid 2005-06-26 01:22:27 UTC
Well, that's not what i meant, i only want to remove @ when it's at the end, i want to keep it when it's in the middle of a word. If you give me some pointer where that accept/reject thing is done i can try to code it myself.
Comment 3 Kurt Hindenburg 2005-06-26 02:32:24 UTC
If you want to hack, look in TEWidget.cpp for word_characters and charClass.  Basically check to see if @ is at the end and if so, ignore it.
Comment 4 Kurt Hindenburg 2005-07-08 22:13:57 UTC
SVN commit 432870 by hindenburg:

Don't select @ at the end of a word when double-clicking; helpful for symbolic links in dir listings.

BUG: 108107


 M  +5 -0      TEWidget.cpp  


--- trunk/KDE/kdebase/konsole/konsole/TEWidget.cpp #432869:432870
@@ -1594,6 +1594,11 @@
      while( ((x<columns-1) || (endSel.y()<lines-1 && m_line_wrapped[endSel.y()])) && charClass(image[i+1].c) == selClass )
      { i++; if (x<columns-1) x++; else {x=0; endSel.ry()++; } }
      endSel.setX(x);
+
+     // In word selection mode don't select @ (64) if at end of word.
+     if ( ( QChar( image[i].c ) == '@' ) && ( ( endSel.x() - bgnSel.x() ) > 0 ) )
+       endSel.setX( x - 1 );
+
      actSel = 2; // within selection
      emit extendSelectionSignal( endSel.x(), endSel.y() );
      emit endSelectionSignal(preserve_line_breaks);