Bug 108066 - Kdeprintfax ignores paper size setting when using Hylafax
Summary: Kdeprintfax ignores paper size setting when using Hylafax
Status: CLOSED FIXED
Alias: None
Product: kdeprint
Classification: Unmaintained
Component: kdeprintfax (show other bugs)
Version: 1.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: KDEPrint Devel Mailinglist
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-24 18:02 UTC by joao
Modified: 2008-12-31 18:47 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Patch to add %page_s to the default HylaFax command (873 bytes, patch)
2006-04-25 15:10 UTC, Ray Lischner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description joao 2005-06-24 18:02:12 UTC
Version:           1.0 (using KDE 3.3.1, SuSE)
Compiler:          gcc version 3.3.3 (SuSE Linux)
OS:                Linux (i686) release 2.6.5-7.155.29-default

When using Hylafax as fax system, Kdeprintfax ignores the Paper Size setting under Page Setup.
It should use the "-s" option to the sendfax command.
Comment 1 Cristian Tibirna 2005-08-22 21:20:20 UTC
UNCONFIRMED (batch reassigning messed this)
Comment 2 joao 2006-03-02 14:48:16 UTC
Does anyone care about fixing this simple bug?
Comment 3 Ray Lischner 2006-04-20 20:23:22 UTC
The functionality is already in kdeprintfax, but was omitted from the default HylaFax command line. Go to Settings>Configure KdeprintFax... and select the System icon. Edit the Command to use %page_s. That will supply the -s option to HylaFax. Note that kdeprintfax has a limitation in that it recognizes only A4 and Letter sizes, specifically, anything that isn't A4, it treats at letter.
Comment 4 joao 2006-04-25 14:29:42 UTC
> Edit the Command to use %page_s.

Well, but that's not how kdeprintfax should work. Editing Command should only be used when there is a need to supply advanced options that are not available in the kdeprintfax GUI. 
In this case, there is a Paper Size option on the GUI, so Kdeprintfax should honor the value set there and supply it to the hylafax client.
Comment 5 Ray Lischner 2006-04-25 15:09:45 UTC
I agree with joao@fraga.com that %page_s should be part of the default HylaFax command. I am attaching a patch to do just that.
Comment 6 Ray Lischner 2006-04-25 15:10:47 UTC
Created attachment 15769 [details]
Patch to add %page_s to the default HylaFax command
Comment 7 Cristian Tibirna 2006-04-27 03:20:47 UTC
SVN commit 534411 by tibirna:

Attempt to make hylafax take into account the paper size settings.
Thanks to Ray Lischner.
BUG:108066


 M  +1 -1      defcmds.h  


--- branches/KDE/3.5/kdebase/kdeprint/kdeprintfax/defcmds.h #534410:534411
@@ -24,7 +24,7 @@
 #include <qstring.h>
 
 #define efax_default_cmd	"%exe_fax %user_{NAME=\"@@\"} %dev_{DEV=@@} PAGE=%page %from_{FROM=@@} send %res %number %files"
-#define hylafax_default_cmd    "%exe_sendfax -n %server_h %res %time_a %enterprise_x %comment_c %email_f -d %name_{@@@}%number %files"
+#define hylafax_default_cmd    "%exe_sendfax -n %server_h %res %page_s %time_a %enterprise_x %comment_c %email_f -d %name_{@@@}%number %files"
 #define	mgetty_default_cmd	"%exe_faxspool %user_F %email_f %name_D %time_t %number %files"
 
 QString defaultCommand(const QString& cmd);
Comment 8 John Layt 2008-12-31 18:47:43 UTC
Closing old Resolved status bug.