Bug 107717 - Add trash to album treeview
Summary: Add trash to album treeview
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-Trash (show other bugs)
Version: 0.7.2
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-19 12:45 UTC by Dik Takken
Modified: 2017-08-14 08:42 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.7.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dik Takken 2005-06-19 12:45:19 UTC
Version:           0.7.2 (using KDE KDE 3.4.1)
OS:                Linux

Please add a trash bin icon to the album treeview. This will allow the user to delete photos by dragging them to the trash bin.
Comment 1 Mikolaj Machowski 2005-06-19 17:30:06 UTC
> Please add a trash bin icon to the album treeview. This will allow the
> user to delete photos by dragging them to the trash bin.


Please don't add a trash bin icon to the album treeview. It is already
crowded and even after future cleanings it still will be crowded. But
adding trash bin icon as default to toolbar could be nice.
Comment 2 Dik Takken 2005-06-19 19:20:49 UTC
Crowded?

I only see two items: 'Albums' and 'Tags'.
Comment 3 Mikolaj Machowski 2005-06-19 23:56:58 UTC
> I only see two items: 'Albums' and 'Tags'.


Open them. And few sublevels (which is default).  You will  have either
scroll down to get to camera node or precious space will be wasted for
trash node.

Also there is problem with interface. What should happen if you click
trash? Show contents of trash? Nonsense - there will be also non-graphic
files, even graphic files could be trashed not from digiKam.
Comment 4 Dik Takken 2005-06-20 10:41:11 UTC
> there will be also non-graphic files, even graphic files could be trashed not from digiKam.

We can solve this problem exactly like Kmail solved it: Create your own trash bin, completely disconnected from the global KDE trash bin. Digikam could create a 'trash' folder in the users photo directory and treat it just like any other album folder, with a few exceptions:

* The folder icon is the trash bin icon
* The thumbs in the trash bin should have a different RMB menu with only a few entries in it
* Items in the trash bin are automatically distroyed after a configurable amount of time
* Each item has a 'Restore' entry in its RMB menu, which puts the photo back where it came from
Comment 5 Mikolaj Machowski 2005-06-20 15:10:35 UTC
Dnia poniedziałek 20 czerwiec 2005 10:41, Dik Takken napisał:
> > there will be also non-graphic files, even graphic files could be
> > trashed not from digiKam.
>
> We can solve this problem exactly like Kmail solved it: Create your own
> trash bin, completely disconnected from the global KDE trash bin.


What with files dumped from this trash?

> a few entries in it * Items in the trash bin are automatically distroyed
> after a configurable amount of time * Each item has a 'Restore' entry in
> its RMB menu, which puts the photo back where it came from


That could also restore tags.

Still don't like placing it in main tree view. Or it will vanish from
sight very quickly when placed below other main nodes. Or will take
precious space for real albums.

I am beginning to like idea of special trash for digiKam objects but
don't like idea of placing it into main tree/panel. Also putting vital
options in RMB is bad from accessibility point of view.

What about putting trash as icon in toolbar, allow for d'n'd there. When
clicked it will open dialog similar to this to download from camera with
options: restore selected, restore all; destroy selected, destroy all.

Bah. Maybe it could serve not only for images but also for tags and
other metadata?
Comment 6 Dik Takken 2005-06-20 19:49:10 UTC
> Still don't like placing it in main tree view. Or it will vanish from sight very quickly when placed below other main nodes.

Why should the trash bin always be in sight? If you have more than just a few albums, no single item will be always in sight. Not the tags, not even the albums themselves. So why should the trash bin be any more important, easier to reach than any particular album? AFAIK Digikam is not built for trashing photo's, rather watching/organising/editing them .. :)

> Or will take precious space for real albums.

If you have 20 Albums and one trash bin, you gain about 5 percent more space by removing the trash bin. Not really stunning. I think you'd better re-organise your album tree if you really want to save space.

> What about putting trash as icon in toolbar, allow for d'n'd there.

I have never ever dragged a file to a toolbar in my life. :) So, I don't think that can ever be intuitive, unless you can make the toolbar icon look like you can drag things on it. No idea how on earth you could do that and what it would look like...
Comment 7 Ted Hansen 2006-01-08 16:41:40 UTC
If you are going to create a separate trash bin, perhaps it should be a separate tab on the tree view. Dragging to it should not be a concern since there is 'move to trash'  on both the main menu and on the right click sub menu. If more 'move to trash' options were desired probably a trash icon on the main toolbar would be the most appropriate.
I am satisfied with using the system trash bin, however.
Comment 8 Joern Ahrens 2006-01-08 19:06:41 UTC
> I am satisfied with using the system trash bin, however
Yes, you are right. There is already (or at least configurable) trash bin at the panel which can be used to drop images.
Comment 9 caulier.gilles 2017-07-17 10:45:02 UTC
This feature is implemented since 5.0.0