Version: (using KDE KDE 3.4.1) Installed from: Compiled From Sources if i draw a image and set it as kicker background, the kicker doesn't look great. could you remove the kicker-border if one select a background image? we can draw the border to the image, if we want one.
SVN commit 424730 by aseigo: don't show a border when we have a panel background. BUG:107272 M +2 -1 container_extension.cpp --- trunk/KDE/kdebase/kicker/kicker/core/container_extension.cpp #424729:424730 @@ -1302,7 +1302,8 @@ { QFrame::paintEvent(e); - if (KickerSettings::transparent()) + if (KickerSettings::transparent() || + KickerSettings::useBackgroundTheme()) { return; }
1) Hey, Aaron, when I made such an ask few months ago, You said that You won't change it. So, changed Your mind? ;) 2) Is this working? I was trying to do this earlier, now I made Your change and the border still exists :(
http://bugs.kde.org/show_bug.cgi?id=102499 Duplicate ;)
the difference is this guy asked for it to be removed when there is a background image (wallpaper) used in the panel. in that specific case it makes sense, just as it does with transparency.
Aaron J. Seigo: you have to change line 203 and 232 (kde 3.4.1) of container_extension.cpp too, i think.
the border still exists in KDE 3.4.2
forgot to reopen
This bug is fixed in 3.5 branch, there is no border on kicker when there is a background image. Please do not reopen kicker bugs if you are not the person they are assigned to! These bugs belong to aseigo and it's up to him to sort out the status of them.
This is not fixed in KDE 3.5. KDE 3.5.6 has in container_extension.cpp: bool ExtensionContainer::needsBorder() const { return !KickerSettings::transparent(); // && !KickerSettings::useBackgroundTheme(); } Is there areason the BackgroundTheme line is commented out?
yes, because background themes created prior to this change were made with the border in mind. either way, something breaks, and this at least doesn't break what is already there.
Please do not mark as fixed what in fact is a wont fix. Aaron, please move on or give people a chance to do so.