Bug 106096 - MenuEntryHeight - menu icon height and submenu icon height
Summary: MenuEntryHeight - menu icon height and submenu icon height
Status: RESOLVED UNMAINTAINED
Alias: None
Product: kicker
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Aaron J. Seigo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-22 10:13 UTC by Mohd Asif Ali Rizwaan
Modified: 2009-05-23 04:38 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
kdebase-3.4.2-SubMenuEntryHeight.patch (1.33 KB, patch)
2005-08-28 02:56 UTC, S.Çağlar ONUR
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mohd Asif Ali Rizwaan 2005-05-22 10:13:11 UTC
Version:           3.4.0 (using KDE 3.4.0, compiled sources)
Compiler:          gcc version 3.3.4
OS:                Linux (i686) release 2.4.29-lck1

I would like to question, why is that the "MenuEntryHeight" feature is hidden in General KDE and available in SuSE (not sure though) etc.?

It is good to see Big icons in KMenu but the Submenus look really awkward.

Please support Submenu icon height like in kickerrc's

[menu]
MenuEntryHeight=32
SubMenuEntryHeight=16

SubMenuEntryHeight will definitely help kmenu look better. thanks.
Comment 1 Aaron J. Seigo 2005-05-22 19:01:22 UTC
and at which point, exactly, do we end up with too much uneccessary configuration? kicker already probably has 2 features for everyone one in the GUI config and this rapidly leads to configuration insanity. the current clock, for instance, is not only a huge beast in terms of resources and performance, but it is also pretty much completely unmaintainable because every whim of a feature that anyone could think of was added.

code path upon code path until it's a mess.

so... how necessary is this feature, really?
also note that this value is used by more than just the kmenu, but by many other menus in kicker now.

i'm going to leave the decision for now up to you, so i'd like you to consider the implications and the true value of the requested feature.
Comment 2 James Sager 2005-07-14 18:36:00 UTC
*** This bug has been confirmed by popular vote. ***
Comment 4 Aqueel Ahmed 2005-07-14 19:13:59 UTC
Dear Aaron J., this feature is popular, and I love the advantages it brings. Like: Easy to see icons; easy to hover menus and submenus, and good appearing submenus with different sizes. This feature IMHO is not an insane wish. Please consider implementing it. 
Comment 5 Aaron J. Seigo 2005-07-14 20:16:47 UTC
a) i'm not impressed with vote spamming and have no desire to encourage it by rewarding it with action

b) if someone provides a patch that works and is of the required quality (which is well defined in kdebase/kicker/HACKING) then i will see about committing it for 3.5
Comment 6 jos poortvliet 2005-07-14 20:26:10 UTC
hey, aaron, maybe just make this default? bigger icons for the 'base' menu, and smaller for the sub menu's. i agree with Mohd Asif Ali Rizwaan it is more usable. of course, it might be configurable in the kickerrc so distributions and advanced users can change it... but it won't add clutter, and make the Kmenu a bit more usable.
Comment 7 Aaron J. Seigo 2005-07-14 21:43:18 UTC
> but it won't add clutter

only in the code =)
Comment 8 Bill Kendrick 2005-07-14 23:52:34 UTC
I was looking for precisely this option when upgrading my dad's KDE box recently.  
Comment 9 Bill Kendrick 2005-07-14 23:52:52 UTC
*** This bug has been confirmed by popular vote. ***
Comment 10 Aaron J. Seigo 2005-07-15 01:43:03 UTC
..
Comment 11 Bojan 2005-07-15 10:31:27 UTC
*** This bug has been confirmed by popular vote. ***
Comment 12 Rob Davies 2005-08-10 23:42:40 UTC
Nice idea and I approve of the look, but I understand the concerns of 'too complex' etc. from Aaron

And another point. Wouldn't the height also have to take account of the # of items in the menu and the vertical screen resolution, otherwise it's possible to end up with a menu taller than the screen! (Unless the code already prevents this of course).

This said... maybe a small/medium/large is enough - kinda like the tiny/small/medium/large/xlarge for the kicker?
Comment 13 Dik Takken 2005-08-11 09:52:42 UTC
I tried bigger icons in the KMenu and it does not fit on the screen (1024x768). I must admit that I also have the most recently used apps in the menu.

This problem might be solved by re-organizing the KMenu: Create one entry called 'Applications' in the KMenu, and put all app categories in there. That really looks a lot cleaner, is easier to navigate (IMHO) and it fits easily, even with huge icons.
Comment 14 Oli Poepperl 2005-08-20 13:51:14 UTC
It`s a good idea. but i would not need another option for the submenus (there are just 1 or 2 submenu levels anyway in menus). quick browser icons are small by default and you can't change their size, can you, that's ok, too. but the menus to access the programs should really contain bigger icons. it's a better look and feel.

please code it, at least the configuration option for icon size in menus.
Comment 15 S.Çağlar ONUR 2005-08-28 02:56:43 UTC
Created attachment 12402 [details]
kdebase-3.4.2-SubMenuEntryHeight.patch

(In reply to comment #5)
> b) if someone provides a patch that works and is of the required quality
(which 
> is well defined in kdebase/kicker/HACKING) then i will see about committing
it 
> for 3.5

Here is the SubMenuEntryHeight patch for KDE 3.4.2, if you are interested i can
try to implement against 3.5
Comment 16 S.Çağlar ONUR 2005-08-28 03:56:02 UTC
Forget this patch, this cannot handle all situations :(
Comment 17 A. Spehr 2009-05-23 04:38:29 UTC
Kicker is currently unmaintained, you can look to your distribution for help, however.