Version: 1.1.0_beta2 (using KDE KDE 3.4.0) Installed from: Slackware Packages OS: Linux The new plugin dialog doesn't allow one to see all the entries for some of the inputs and outputs. At first it looks like you can resize to see the rest of the entries, but resizing doesn't do anything. This might be related to bug 87006
Created attachment 10923 [details] New Plugin Dialog screen shot. Screenshot showing new plugin dialog for Fit Linear where resizing doesn't help show the additional output vectors.
After playing with it some more, sometimes it works, and sometimes it doesn't. We aren't yet sure in what exact cases it does and doesn't. Very weird.
This has been a bug ever since I made that dialog. I never did track down the final cause of it. I'll search again this weekend.
SVN commit 411662 by staikos: some of the geometry fixes required for bug 105220 CCBUG: 105220 M +2 -3 trunk/extragear/graphics/kst/kst/kstfilterdialog_i.cpp M +3 -5 trunk/extragear/graphics/kst/kst/kstfitdialog_i.cpp M +2 -3 trunk/extragear/graphics/kst/kst/kstplugindialog_i.cpp --- trunk/extragear/graphics/kst/kst/kstfilterdialog_i.cpp #411661:411662 @@ -174,8 +174,8 @@ void KstFilterDialogI::fixupLayout() { - _frameWidget->resize(_frameWidget->sizeHint()); - _pluginFrame->resize(_pluginFrame->sizeHint()); + _frameWidget->updateGeometry(); + _pluginFrame->updateGeometry(); resize(sizeHint()); setMinimumSize(size()); updateGeometry(); @@ -541,7 +541,6 @@ // Create a new one QGridLayout *topGrid = dynamic_cast<QGridLayout*>(_pluginFrame->layout()); if (topGrid) { - topGrid->invalidate(); topGrid->addWidget(_frameWidget = new QWidget(_pluginFrame, "Frame Widget"), 0, 0); } else { kdError() << "Somehow we lost the grid!" << endl; --- trunk/extragear/graphics/kst/kst/kstfitdialog_i.cpp #411661:411662 @@ -86,8 +86,7 @@ void KstFitDialogI::show_setCurve(const QString& strCurve, const QString& strPlotName, const QString& strWindow) { - - KstBaseCurvePtr curve; + KstBaseCurvePtr curve; KstBaseCurveList curves = kstObjectSubList<KstDataObject, KstBaseCurve>(KST::dataObjectList); KstPluginList c = kstObjectSubList<KstDataObject, KstPlugin>(KST::dataObjectList); QString new_label; @@ -183,8 +182,8 @@ void KstFitDialogI::fixupLayout() { - _frameWidget->resize(_frameWidget->sizeHint()); - _pluginFrame->resize(_pluginFrame->sizeHint()); + _frameWidget->updateGeometry(); + _pluginFrame->updateGeometry(); resize(sizeHint()); setMinimumSize(size()); updateGeometry(); @@ -625,7 +624,6 @@ // Create a new one QGridLayout *topGrid = dynamic_cast<QGridLayout*>(_pluginFrame->layout()); if (topGrid) { - topGrid->invalidate(); topGrid->addWidget(_frameWidget = new QWidget(_pluginFrame, "Frame Widget"), 0, 0); } else { kdError() << "Somehow we lost the grid!" << endl; --- trunk/extragear/graphics/kst/kst/kstplugindialog_i.cpp #411661:411662 @@ -299,8 +299,8 @@ void KstPluginDialogI::fixupLayout() { - _frameWidget->resize(_frameWidget->sizeHint()); - _pluginFrame->resize(_pluginFrame->sizeHint()); + _frameWidget->updateGeometry(); + _pluginFrame->updateGeometry(); resize(sizeHint()); setMinimumSize(size()); updateGeometry(); @@ -804,7 +804,6 @@ // Create a new one QGridLayout *topGrid = dynamic_cast<QGridLayout*>(_pluginFrame->layout()); if (topGrid) { - topGrid->invalidate(); topGrid->addWidget(_frameWidget = new QWidget(_pluginFrame, "Frame Widget"), 0, 0); } else { kdError() << "Somehow we lost the grid!" << endl;
SVN commit 426246 by rchern: Don't cut off entries in plugin dialog. Currently plugins with scalar selectors widen the dialog a lot because of the long scalar names. CCMAIL: 105220@bugs.kde.org M +106 -81 kstplugindialog_i.cpp M +9 -1 kstplugindialog_i.h M +102 -81 plugindialog.ui
done
This also affects the fit and filter dialog which are just copies of the plugin dialog. (and really need to be refactored)
Also a textedit is the wrong widget to use for the description. it implies text input is possible. The input and output fields should all be aligned vertically.
SVN commit 426592 by rchern: Align input and output fields, and use text label for description CCMAIL: 105220@bugs.kde.org M +53 -57 kstplugindialog_i.cpp M +1 -3 kstplugindialog_i.h M +4 -28 plugindialog.ui
SVN commit 427463 by rchern: Filter dialog inherits plugin dialog CCMAIL: 105220@bugs.kde.org M +0 -1 Makefile.am D filterdialog.ui M +24 -225 kstfilterdialog_i.cpp M +4 -19 kstfilterdialog_i.h
All looks good now... The question is, can we backport this? I can apply the patch but I would need an aggregation of all the related commits.
The following should be all the related commits: 411662 426246 426592 426659 426660 427448 427454 427463