Version: (using KDE KDE 3.4.0) Installed from: SuSE RPMs OS: Linux When retrieving the text-shadow property value via DOM, any commas are omitted... e.g. this.style.textShadow turns style="text-shadow: red 2px 2px 2px, orange 4px 4px 2px" into red 2px 2px 2pxorange 4px 4px 2px and not the expected red 2px 2px 2px, orange 4px 4px 2px
Created attachment 10901 [details] testcase Click on the text to see the bug
Tricky. I thought it was easy to fix in CSSValueListImpl::cssText(), but not all valuelists are comma-separated, apparently. See new testcase, which shows that text-shadow may be comma separated, but text-decoration is space separated, and both things get stuffed into the same class, so I don't know how to differenciate them. I hope another developer will find out :)
Created attachment 10902 [details] new testcase
Created attachment 10903 [details] patch which adds a comma, but which breaks style.textDecoration
Created attachment 20501 [details] should fix without breaking other properties tested with kde4, not on the 3.5 branch
Created attachment 20555 [details] another patch using an enum instead of a DOMString This patch replaces my previous one; it's using a enum and a bitfielded member as discussed with SadEagle on irc.
Has the patch been applied on KDE4 ?
Doesn't work for me, neither on 3.5.9 nor on trunk.
not sure why this patch got forgotten... sorry Vincent ;-/ I'll modify it a bit to add spaces between properties, extend it to other relevant CSS lists I can think of, and commit the result.
SVN commit 1046456 by ggarand: need to distinguish at least two types of CSS value lists : those that use the comma as a separator when flattened to a string, and those that use the space. initial patch by Vincent Ricard <magic@magicninja.org>, with input from dfaure and SadEagle, extended to apply to (hopefully) all relevant properties. BUG: 105108 M +1 -1 css/css_renderstyledeclarationimpl.cpp M +1 -1 css/css_svgcssparser.cpp M +7 -1 css/css_valueimpl.cpp M +8 -1 css/css_valueimpl.h M +3 -3 css/css_webfont.cpp M +5 -5 css/cssparser.cpp M +1 -1 svg/SVGFontFaceElement.cpp M +1 -1 svg/SVGFontFaceSrcElement.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1046456