Version: (using KDE KDE 3.4.0) Installed from: Compiled From Sources Compiler: GCC-3.4.3 OS: Linux As shown in the attachment, the menu entries: Previous Page Next Page have the wrong icons when using the KDE Standard Actions in KDELibs. It appears that in the CrystalSVG icon theme that this was addressed by changing the icons. That does not really address the issue since the icons: previous next are needed for some other uses and if you use all 4 icons on the tool bar the user will be confused. For example: if KPDF uses 6 icons on the toolbar, like XPDF, they won't all be different in the CrystalSVG icon style. -- JRT
Created attachment 10691 [details] KDEClassic screenshot Screenshot of the menu showing "Previous Page" & "Next Page".
Created attachment 10692 [details] Patch to change. This patch changes the icon for: "Previous Page" to "Back" and the icon for: "Next Page" to "Forward". This fixes the problem with the bug. However, the CrystalSVG icons "previous" & "next" still need to be changed.
Created attachment 10718 [details] Icons to fix the icon issue These are Marco Martin's icons. Perhaps the small ones still need a little work, but these are different icons for: "previous" & "next" in the CrystalSVG style. And, he made SVG icons. -- JRT
Created attachment 10719 [details] The icon "next"
Created attachment 10720 [details] The icon "previous"
Please read the patch, this is not an Artist issue. -- JRT
Changing back to KDELibs. -- JRT
James, why this is not a kde-artists issue? They have been taking care of these issues. It seems to me that it is a kde-artists issue, in particular, judging if a new icon complies with the kde/crystal icon guidelines. Also, I would like to add a comment about the icons you are suggesting: KDE currenlty mixes the "forward / backward in history" icons, with "forward / next" "directional" icons. The usage all around KDE is not consistent, and I can think of many instances where the user may be confused. Since there no standard, the applications start creating their own icons to make this difference clear. There are many different forward / next icons in KDE, and we shouldn't add another one, we should try to make consistent use of what we have. Or in other words, why not use the action-1rightarrow or action-1leftarrow instead, for all "forward / next" "directional" icons and use the action-next/forward for"forward / backward in history"?
Correcting my confusing post: I will be happy if you use the the action-1rightarrow or action-1leftarrow *or* the action-next/previous you are proposing for all "previous / next" "directional" actions and use the action-back/forward for "forward / backward in history" actions. Then, we can check all KDE apps for conformance. Just to make it clear: I agree with the solution you are proposing for this bug. Even more, I think we should include in this discussion if we should use the "arrow" icons *or* the "previous/next" icons for the directional actions, and try to check the conformance of the applications.
I hate to be difficult, but the patch (second attachment) has not been applied yet and I believe that this patch is a KDELibs issue. Yes, Icons need to be changed, but applying the patch needs to be done *first*.
Created attachment 11262 [details] Version 1.01 of the icons Tweaked version of the icons.
Created attachment 11608 [details] Version 20 of the patch Patch modified to include the use of these icons in: kdelibs/kdeui/kstdaction.cpp
Created attachment 12234 [details] Version 03 Must have been having bad day ;-( I think that this one is correct.
I have this fixed so I am reassigning it to myself. Will commit to 3.5.
Patch committed to 3.5 BRANCH