Bug 103851 - Channel names with '/' characters do not get linked/highlighted entirely
Summary: Channel names with '/' characters do not get linked/highlighted entirely
Status: RESOLVED FIXED
Alias: None
Product: konversation
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-14 03:27 UTC by Michael Gabilondo
Modified: 2010-07-01 16:19 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Gabilondo 2005-04-14 03:27:29 UTC
Version:           0.17 #3011 (using KDE KDE 3.3.2)
Installed from:    Debian testing/unstable Packages
Compiler:          gcc (GCC) 3.3.5 (Debian 1:3.3.5-8) 
OS:                Linux

If someone says a channel name like #gnu/linux, only the #gnu part is highlighted and linked. It should consider / as being part of channel names.
Comment 1 Ismail Donmez 2005-04-14 07:09:03 UTC
CVS commit by cartman: 

Accept / in channel name
BUG:103851


  M +1 -1      common.cpp   1.52


--- kdeextragear-2/konversation/konversation/common.cpp  #1.51:1.52
@@ -57,5 +57,5 @@ QString tagURLs(const QString& text, con
 
   if(filteredLine.contains("#")) {
-    QRegExp chanExp("(^|\\s)(#[\\w+-.]{2,})");
+    QRegExp chanExp("(^|\\s)(#[\\w+-/.]{2,})");
     filteredLine.replace(chanExp, link);
   }
Comment 2 Ismail Donmez 2010-07-01 16:03:08 UTC
commit 414899eed7d51adbfbf4dc189a1446c4edfc8b73
Author: İsmail Dönmez <ismail@kde.org>
Date:   Thu Apr 14 05:08:56 2005 +0000

    Accept / in channel name
    BUG:103851
    
    svn path=/trunk/kdeextragear-2/konversation/; revision=405477

diff --git a/konversation/common.cpp b/konversation/common.cpp
index c4eb449..efab254 100644
--- a/konversation/common.cpp
+++ b/konversation/common.cpp
@@ -56,7 +56,7 @@ QString tagURLs(const QString& text, const QString& fromNick, bool useCustomColo
   }
 
   if(filteredLine.contains("#")) {
-    QRegExp chanExp("(^|\\s)(#[\\w+-.]{2,})");
+    QRegExp chanExp("(^|\\s)(#[\\w+-/.]{2,})");
     filteredLine.replace(chanExp, link);
   }
Comment 3 Ismail Donmez 2010-07-01 16:19:40 UTC
commit 414899eed7d51adbfbf4dc189a1446c4edfc8b73
Author: İsmail Dönmez <ismail@kde.org>
Date:   Thu Apr 14 05:08:56 2005 +0000

    Accept / in channel name
    BUG:103851
    
    svn path=/trunk/kdeextragear-2/konversation/; revision=405477

diff --git a/konversation/common.cpp b/konversation/common.cpp
index c4eb449..efab254 100644
--- a/konversation/common.cpp
+++ b/konversation/common.cpp
@@ -56,7 +56,7 @@ QString tagURLs(const QString& text, const QString& fromNick, bool useCustomColo
   }
 
   if(filteredLine.contains("#")) {
-    QRegExp chanExp("(^|\\s)(#[\\w+-.]{2,})");
+    QRegExp chanExp("(^|\\s)(#[\\w+-/.]{2,})");
     filteredLine.replace(chanExp, link);
   }