Version: 0.7.2 (using KDE KDE 3.3.2) OS: Linux The image editor has multiple menus that have very similar names: * Edit * Image * Fix * Transform * Filters All of these menus suggest to change something about the image, but it is hard to guess what. The result is that it is impossible to learn where to find a specific function. The menu structure of the GIMP is a lot easier to learn (but it could still be improved). Please merge at least _some_ of the menus into one. Some more suggestions: * The 'Edit Comments and Tags' option should definitely be moved into the 'Edit' menu. * The 'Properties' option might better be in the 'File' menu. * The 'Full Screen' option should really be in the 'View' menu. * Is the 'Copy' entry in the 'Edit' menu supposed to do something?
> The image editor has multiple menus that have very similar names: > > * Edit Actions menu and history > * Image Image informations and decorative transformations > * Fix Corrected and improved image > * Transform Geometry transformation. > * Filters image filters > > All of these menus suggest to change something about the image, but it is > hard to guess what. The result is that it is impossible to learn where to > find a specific function. The menu structure of the GIMP is a lot easier to > learn (but it could still be improved). Gimp interface is certainly not a reference (for me (:=))) ! > Please merge at least _some_ of the > menus into one. Into one ? > > Some more suggestions: > > * The 'Edit Comments and Tags' option should definitely be moved into the > 'Edit' menu. No, it's relevant of image informations... > > * The 'Properties' option might better be in the 'File' menu. Histogram information is relevant of current image who can be modified in editor and not corresponding to the image file. > > * The 'Full Screen' option should really be in the 'View' menu. KDE standard ! > > * Is the 'Copy' entry in the 'Edit' menu supposed to do something? Copying image selection to clipboard. Paste it in Kword for exemple... Gilles Caulier
I could have guessed that _you_ know exactly what each menu is for, but that does not make them intuitive. :) I know that intuitiveness is not the same thing for everyone, but the users that I have seen working with DigiKam spent much time searching all of these menus every time they needed to find the right option. About the Full Screen KDE standard: I will ask on the usability list. About the Properties option: Somehow the 'Properties' option is tightly connected to the 'File' menu in my mind. That's probably why I always keep looking for it in the File menu. Maybe it could be renamed to 'Image Info' or 'Image Statistics' to avoid this confusion.
SVN commit 643216 by cgilles: digiKam from trunk : Usability issue in Image Editor : Merge Blowup and Resize tools to reduce duplicate menu entries and functions. To packagers : Blowup tool is removed to DigikamImagePlugins. Please update you package rule for 0.9.2 release To translators : Blowup i18n are moved to digikam.po. Take a care. Blowup plugin trnaslations files are invalid now. CCMAIL: digikam-devel@kde.org CCBUGS: 103244 M +1 -0 digikam/digikam/Makefile.am M +1 -3 digikam/showfoto/Makefile.am M +1 -4 digikam/utilities/imageeditor/canvas/Makefile.am M +5 -3 digikam/utilities/imageeditor/editor/Makefile.am M +3 -11 digikam/utilities/imageeditor/editor/editorwindow.cpp M +3 -1 digikam/utilities/imageeditor/tools/Makefile.am AM digikam/utilities/imageeditor/tools/imageresize.cpp [License: GPL] AM digikam/utilities/imageeditor/tools/imageresize.h [License: GPL] D digikam/utilities/imageeditor/tools/imageresizedlg.cpp D digikam/utilities/imageeditor/tools/imageresizedlg.h M +1 -1 digikamimageplugins/Makefile.am M +3 -8 digikamimageplugins/README --- trunk/extragear/graphics/digikam/digikam/Makefile.am #643215:643216 @@ -103,6 +103,7 @@ $(top_builddir)/digikam/libs/widgets/libwidgets.la \ $(top_builddir)/digikam/libs/dialogs/libdialog.la \ $(top_builddir)/digikam/libs/jpegutils/libjpegutils.la \ + $(top_builddir)/digikam/libs/dimg/libdimg.la \ $(top_builddir)/digikam/libs/imageproperties/libimagepropertiesdigikam.la \ $(top_builddir)/digikam/libs/threadimageio/libthreadimageio.la \ $(top_builddir)/digikam/libs/greycstoration/libgreycstoration.la \ --- trunk/extragear/graphics/digikam/showfoto/Makefile.am #643215:643216 @@ -14,13 +14,12 @@ -I$(top_srcdir)/digikam/libs/dmetadata \ -I$(top_srcdir)/digikam/libs/threadimageio \ -I$(top_srcdir)/digikam/digikam \ - $(LIBKEXIV2_CFLAGS) \ -I$(top_srcdir)/digikam/utilities/slideshow \ -I$(top_srcdir)/digikam/utilities/imageeditor/canvas \ -I$(top_srcdir)/digikam/utilities/imageeditor/editor \ -I$(top_srcdir)/digikam/utilities/imageeditor/tools \ -I$(top_srcdir)/digikam/utilities/splashscreen \ - $(LIBKDCRAW_CFLAGS) $(all_includes) + $(LIBKEXIV2_CFLAGS) $(LIBKDCRAW_CFLAGS) $(all_includes) showfoto_SOURCES = main.cpp showfoto.cpp @@ -28,7 +27,6 @@ $(top_builddir)/digikam/libs/dialogs/libdialogshowfoto.la \ $(top_builddir)/digikam/libs/imageproperties/libimagepropertiesshowfoto.la \ $(top_builddir)/digikam/libs/thumbbar/libthumbbar.la \ - $(top_builddir)/digikam/utilities/imageeditor/canvas/libdimgcanvas.la \ $(top_builddir)/digikam/utilities/imageeditor/editor/libshowfoto.la \ $(top_builddir)/digikam/utilities/splashscreen/libsplashscreen.la \ $(top_builddir)/digikam/utilities/slideshow/libslideshow.la \ --- trunk/extragear/graphics/digikam/utilities/imageeditor/canvas/Makefile.am #643215:643216 @@ -7,8 +7,6 @@ undoaction.cpp undomanager.cpp \ imagepluginloader.cpp imageplugin.cpp -libdimgcanvas_la_LIBADD = $(top_builddir)/digikam/libs/dimg/libdimg.la - libdimgcanvas_la_LDFLAGS = $(all_libraries) $(KDE_RPATH) $(LIB_TIFF) INCLUDES = -I$(top_srcdir)/digikam/digikam \ @@ -16,11 +14,10 @@ -I$(top_srcdir)/digikam/libs/dimg/filters \ -I$(top_srcdir)/digikam/libs/dmetadata \ -I$(top_srcdir)/digikam/libs/dialogs \ - $(LIBKEXIV2_CFLAGS) \ -I$(top_srcdir)/digikam/libs/histogram \ -I$(top_srcdir)/digikam/libs/threadimageio \ -I$(top_srcdir)/digikam/utilities/splashscreen \ - $(LIBKDCRAW_CFLAGS) $(all_includes) + $(LIBKEXIV2_CFLAGS) $(LIBKDCRAW_CFLAGS) $(all_includes) digikaminclude_HEADERS = imageplugin.h --- trunk/extragear/graphics/digikam/utilities/imageeditor/editor/Makefile.am #643215:643216 @@ -12,7 +12,10 @@ libshowfoto_la_LDFLAGS = $(all_libraries) $(KDE_RPATH) $(LIB_KDEPRINT) -libshowfoto_la_LIBADD = $(top_builddir)/digikam/utilities/imageeditor/tools/libdimgeditortools.la \ +libshowfoto_la_LIBADD = $(top_builddir)/digikam/libs/dimg/libdimg.la \ + $(top_builddir)/digikam/utilities/imageeditor/canvas/libdimgcanvas.la \ + $(top_builddir)/digikam/libs/greycstoration/libgreycstoration.la \ + $(top_builddir)/digikam/utilities/imageeditor/tools/libdimgeditortools.la \ $(top_builddir)/digikam/libs/widgets/libwidgets.la INCLUDES = -I$(top_srcdir)/digikam/digikam \ @@ -24,13 +27,12 @@ -I$(top_srcdir)/digikam/libs/dimg/filters \ -I$(top_srcdir)/digikam/libs/imageproperties \ -I$(top_srcdir)/digikam/libs/threadimageio \ - $(LIBKEXIV2_CFLAGS) \ -I$(top_srcdir)/digikam/utilities/setup \ -I$(top_srcdir)/digikam/utilities/slideshow \ -I$(top_srcdir)/digikam/utilities/imageeditor/canvas \ -I$(top_srcdir)/digikam/utilities/imageeditor/tools \ -I$(top_builddir)/digikam/libs/dialogs \ - $(LIBKDCRAW_CFLAGS) $(all_includes) + $(LIBKEXIV2_CFLAGS) $(LIBKDCRAW_CFLAGS) $(all_includes) digikaminclude_HEADERS = imageiface.h --- trunk/extragear/graphics/digikam/utilities/imageeditor/editor/editorwindow.cpp #643215:643216 @@ -70,7 +70,6 @@ #include <kstatusbar.h> #include <kprogress.h> #include <kwin.h> -#include <kled.h> // Local includes. @@ -80,7 +79,7 @@ #include "dimginterface.h" #include "imageplugin.h" #include "imagepluginloader.h" -#include "imageresizedlg.h" +#include "imageresize.h" #include "imageprint.h" #include "filesaveoptionsbox.h" #include "statusprogressbar.h" @@ -560,15 +559,8 @@ void EditorWindow::slotResize() { - int width = m_canvas->imageWidth(); - int height = m_canvas->imageHeight(); - - ImageResizeDlg dlg(this, &width, &height); - - if (dlg.exec() == QDialog::Accepted && - (width != m_canvas->imageWidth() || - height != m_canvas->imageHeight())) - m_canvas->resizeImage(width, height); + ImageResize dlg(this); + dlg.exec(); } void EditorWindow::slotAboutToShowUndoMenu() --- trunk/extragear/graphics/digikam/utilities/imageeditor/tools/Makefile.am #643215:643216 @@ -2,13 +2,15 @@ noinst_LTLIBRARIES = libdimgeditortools.la -libdimgeditortools_la_SOURCES = imageresizedlg.cpp imageprint.cpp +libdimgeditortools_la_SOURCES = imageresize.cpp imageprint.cpp libdimgeditortools_la_LDFLAGS = $(all_libraries) $(KDE_RPATH) $(LIB_KDEPRINT) INCLUDES= -I$(top_srcdir)/digikam/digikam \ -I$(top_srcdir)/digikam/libs/dimg \ -I$(top_srcdir)/digikam/libs/dimg/filters \ + -I$(top_srcdir)/digikam/libs/dmetadata \ + -I$(top_srcdir)/digikam/libs/greycstoration \ -I$(top_srcdir)/digikam/utilities/imageeditor/canvas \ -I$(top_srcdir)/digikam/utilities/imageeditor/editor \ $(all_includes) ** trunk/extragear/graphics/digikam/utilities/imageeditor/tools/imageresize.cpp #property svn:eol-style + native ** trunk/extragear/graphics/digikam/utilities/imageeditor/tools/imageresize.h #property svn:eol-style + native --- trunk/extragear/graphics/digikamimageplugins/Makefile.am #643215:643216 @@ -2,7 +2,7 @@ raindrop filmgrain freerotation adjustcurves sheartool antivignetting \ lensdistortion perspective border blurfx distortionfx superimpose \ inserttext infrared channelmixer texture whitebalance restoration \ - inpainting blowup refocus hotpixels + inpainting refocus hotpixels AUTOMAKE_OPTIONS = foreign --- trunk/extragear/graphics/digikamimageplugins/README #643215:643216 @@ -37,16 +37,11 @@ 24) WhiteBalance : A plugin to correct picture white color balance. 25) Restoration : An advanced filter to restore photograph using CImg library. 26) Inpainting : An advanced filter to inpaint photograph area using CImg library. -27) Blowup : An advanced filter to blowup photograph using CImg library. -28) Refocus : An advanced sharpness editor based on deconvolution filter to refocus a photograph. -29) HotPixels : A plugin to remove Stuff/Hot Pixels from pictures taken with deficient camera CCD. +27) Refocus : An advanced sharpness editor based on deconvolution filter to refocus a photograph. +28) HotPixels : A plugin to remove Stuff/Hot Pixels from pictures taken with deficient camera CCD. -Visit the web project pages available at these url: +Visit the web project page available at this url: http://www.digikam.org -DIGIKAM : http://www.digikam.org -DIGIKAMIMAGEPLUGINS : http://extragear.kde.org/apps/digikamimageplugins - - -- CONTACT ------------------------------------------------------------ If you have questions, comments, suggestions to make do email at :
SVN commit 644093 by cgilles: digiKam from trunk : Usability issue in Image Editor : Merge Unsharp Mask and Sharp tools to reduce duplicate menu entries and functions. We will provide just one menu entrie to sharp an image : Fix/Sharp. The Sharp tool will become a Sharpness Editor. I will merge Refocus tool later. To packagers : Unsharp Mask tool is removed to DigikamImagePlugins. Please update you package rule for 0.9.2 release To translators : Unsharp Mask i18n are moved to digikam.po. Take a care. Unsharp Mask plugin translations files are invalid now. Gerhard : You just need to merge the Unsharp Mask handbook content to digiKam handbook as well. The Unsharp Mask tool options are unchanged. CCMAIL: digikam-devel@kde.org CCBUGS: 103244 M +6 -2 digikam/imageplugins/Makefile.am D digikam/imageplugins/imageeffect_sharpen.cpp D digikam/imageplugins/imageeffect_sharpen.h A digikam/imageplugins/sharpnesseditor (directory) A digikam/imageplugins/sharpnesseditor/imageeffect_sharpen.cpp digikam/imageplugins/imageeffect_sharpen.cpp#644056 [License: GPL] A digikam/imageplugins/sharpnesseditor/imageeffect_sharpen.h digikam/imageplugins/imageeffect_sharpen.h#644056 [License: GPL] A digikam/imageplugins/sharpnesseditor/unsharp.cpp digikamimageplugins/unsharp/unsharp.cpp#644056 [License: GPL] A digikam/imageplugins/sharpnesseditor/unsharp.h digikamimageplugins/unsharp/unsharp.h#644056 [License: GPL] M +1 -1 digikamimageplugins/Makefile.am M +21 -22 digikamimageplugins/README D digikamimageplugins/unsharp/Makefile.am D digikamimageplugins/unsharp/digikamimageplugin_unsharp.desktop D digikamimageplugins/unsharp/digikamimageplugin_unsharp_ui.rc D digikamimageplugins/unsharp/hi128-action-unsharpedmask.png D digikamimageplugins/unsharp/hi16-action-unsharpedmask.png D digikamimageplugins/unsharp/hi22-action-unsharpedmask.png D digikamimageplugins/unsharp/hi32-action-unsharpedmask.png D digikamimageplugins/unsharp/hi48-action-unsharpedmask.png D digikamimageplugins/unsharp/hi64-action-unsharpedmask.png D digikamimageplugins/unsharp/hisc-action-unsharpedmask.svgz D digikamimageplugins/unsharp/imageeffect_unsharp.cpp D digikamimageplugins/unsharp/imageeffect_unsharp.h D digikamimageplugins/unsharp/imageplugin_unsharp.cpp D digikamimageplugins/unsharp/imageplugin_unsharp.h D digikamimageplugins/unsharp/unsharp.cpp D digikamimageplugins/unsharp/unsharp.h --- trunk/extragear/graphics/digikam/imageplugins/Makefile.am #644092:644093 @@ -1,3 +1,5 @@ +SUBDIRS = sharpnesseditor +COMPILE_FIRST = sharpnesseditor METASOURCES = AUTO INCLUDES = -I$(top_srcdir)/digikam/utilities/imageeditor/editor \ @@ -14,9 +16,10 @@ -I$(top_srcdir)/digikam/libs/dmetadata \ -I$(top_srcdir)/digikam/libs/dimg/filters \ -I$(top_srcdir)/digikam/digikam \ + -I$(top_srcdir)/digikam/imageplugins/sharpnesseditor \ $(all_includes) -digikamimageplugin_core_la_SOURCES = hspreviewwidget.cpp imageplugin_core.cpp imageeffect_sharpen.cpp \ +digikamimageplugin_core_la_SOURCES = hspreviewwidget.cpp imageplugin_core.cpp \ imageeffect_autocorrection.cpp imageeffect_bwsepia.cpp \ imageeffect_ratiocrop.cpp imageeffect_rgb.cpp \ imageeffect_redeye.cpp imageeffect_blur.cpp \ @@ -25,9 +28,10 @@ noinst_HEADERS = imageeffect_autocorrection.h imageeffect_blur.h imageeffect_hsl.h \ imageeffect_ratiocrop.h imageeffect_rgb.h imageplugin_core.h imageeffect_bcg.h \ imageeffect_bwsepia.h imageeffect_iccproof.h imageeffect_redeye.h \ - imageeffect_sharpen.h hspreviewwidget.h imageplugin_core.h + hspreviewwidget.h imageplugin_core.h digikamimageplugin_core_la_LIBADD = $(LIB_KPARTS) \ + $(top_builddir)/digikam/imageplugins/sharpnesseditor/libsharpnesseditor.la \ $(top_builddir)/digikam/digikam/libdigikam.la digikamimageplugin_core_la_LDFLAGS = -module $(KDE_PLUGIN) $(all_libraries) --- trunk/extragear/graphics/digikamimageplugins/Makefile.am #644092:644093 @@ -1,4 +1,4 @@ -SUBDIRS = common adjustlevels colorfx noisereduction oilpaint emboss charcoal unsharp \ +SUBDIRS = common adjustlevels colorfx noisereduction oilpaint emboss charcoal \ raindrop filmgrain freerotation adjustcurves sheartool antivignetting \ lensdistortion perspective border blurfx distortionfx superimpose \ inserttext infrared channelmixer texture whitebalance restoration \ --- trunk/extragear/graphics/digikamimageplugins/README #644092:644093 @@ -17,28 +17,27 @@ 4) OilPaint : An oil painting effect filter. 5) Emboss : An embossed image effect filter. 6) Charcoal : A charcoal drawing image effect filter. - 7) Unsharp : An unsharp mask image filter. - 8) RainDrop : A plugin to add rain-drops randomly over a picture. - 9) FilmGrain : A plugin to add film grain over an image. -10) FreeRotation : A plugin to perform image rotation with a free angle in degrees. -11) AdjustCurves : A plugin to adjust manually the histogram curves. -12) ShearTool : A plugin to shear a picture. -13) AntiVignetting : A plugin to reduce image vignetting generated by wide lens. -14) LensDistortion : A plugin to reduce optical distortions generated by wide lens. -15) SuperImpose : A plugin to superimpose an image template to a picture. -16) Perpective : A plugin to adjust perpective of picture. -17) Border : A plugin to add a decorative border around a picture. -18) InsertText : A plugin to add text over a picture. -19) Infrared : A plugin to simulate infrared film. -20) ChannelMixer : A color channels mixer tool. -21) BlurFX : Blurring special effects package. -22) DistortionFX : Distortion special effects package. -23) Texture : A plugin to apply a decorative texture over a picture. -24) WhiteBalance : A plugin to correct picture white color balance. -25) Restoration : An advanced filter to restore photograph using CImg library. -26) Inpainting : An advanced filter to inpaint photograph area using CImg library. -27) Refocus : An advanced sharpness editor based on deconvolution filter to refocus a photograph. -28) HotPixels : A plugin to remove Stuff/Hot Pixels from pictures taken with deficient camera CCD. + 7) RainDrop : A plugin to add rain-drops randomly over a picture. + 8) FilmGrain : A plugin to add film grain over an image. + 9) FreeRotation : A plugin to perform image rotation with a free angle in degrees. +10) AdjustCurves : A plugin to adjust manually the histogram curves. +11) ShearTool : A plugin to shear a picture. +12) AntiVignetting : A plugin to reduce image vignetting generated by wide lens. +13) LensDistortion : A plugin to reduce optical distortions generated by wide lens. +14) SuperImpose : A plugin to superimpose an image template to a picture. +15) Perpective : A plugin to adjust perpective of picture. +16) Border : A plugin to add a decorative border around a picture. +17) InsertText : A plugin to add text over a picture. +18) Infrared : A plugin to simulate infrared film. +19) ChannelMixer : A color channels mixer tool. +20) BlurFX : Blurring special effects package. +21) DistortionFX : Distortion special effects package. +22) Texture : A plugin to apply a decorative texture over a picture. +23) WhiteBalance : A plugin to correct picture white color balance. +24) Restoration : An advanced filter to restore photograph using CImg library. +25) Inpainting : An advanced filter to inpaint photograph area using CImg library. +26) Refocus : An advanced sharpness editor based on deconvolution filter to refocus a photograph. +27) HotPixels : A plugin to remove Stuff/Hot Pixels from pictures taken with deficient camera CCD. Visit the web project page available at this url: http://www.digikam.org
SVN commit 644148 by cgilles: digiKam from trunk : Usability issue in Image Editor : Merge Refocus and Sharp tools to reduce duplicate menu entries and functions. Now, the Sharpness Editor is complete. Using Fix/Sharpen menu entry, you can apply Simple Sharp or Unsharp Mask or Refocus corrections. To packagers : Refocus tool is removed to DigikamImagePlugins. Please update you package rule for 0.9.2 release To translators : Refocus i18n are moved to digikam.po. Take a care. Refocus plugin translations files are invalid now. Gerhard : You just need to merge the Refocus handbook content to digiKam handbook as well. The Refocus tool options are unchanged. CCMAIL: digikam-devel@kde.org CCBUGS: 103244 M +8 -2 digikam/imageplugins/sharpnesseditor/Makefile.am A digikam/imageplugins/sharpnesseditor/clapack (directory) digikamimageplugins/refocus/clapack#644102 M +302 -20 digikam/imageplugins/sharpnesseditor/imageeffect_sharpen.cpp M +14 -1 digikam/imageplugins/sharpnesseditor/imageeffect_sharpen.h A digikam/imageplugins/sharpnesseditor/matrix.cpp digikamimageplugins/refocus/matrix.cpp#644102 [License: GPL] A digikam/imageplugins/sharpnesseditor/matrix.h digikamimageplugins/refocus/matrix.h#644102 [License: GPL] A digikam/imageplugins/sharpnesseditor/refocus.cpp digikamimageplugins/refocus/refocus.cpp#644102 [License: GPL] A digikam/imageplugins/sharpnesseditor/refocus.h digikamimageplugins/refocus/refocus.h#644102 [License: GPL] M +1 -1 digikamimageplugins/Makefile.am M +1 -2 digikamimageplugins/README D digikamimageplugins/refocus/Makefile.am D digikamimageplugins/refocus/clapack (directory) D digikamimageplugins/refocus/digikamimageplugin_refocus.desktop [TRAILING SPACE] D digikamimageplugins/refocus/digikamimageplugin_refocus_ui.rc D digikamimageplugins/refocus/hi128-action-refocus.png D digikamimageplugins/refocus/hi16-action-refocus.png D digikamimageplugins/refocus/hi22-action-refocus.png D digikamimageplugins/refocus/hi32-action-refocus.png D digikamimageplugins/refocus/hi48-action-refocus.png D digikamimageplugins/refocus/hi64-action-refocus.png D digikamimageplugins/refocus/imageeffect_refocus.cpp D digikamimageplugins/refocus/imageeffect_refocus.h D digikamimageplugins/refocus/imageplugin_refocus.cpp D digikamimageplugins/refocus/imageplugin_refocus.h D digikamimageplugins/refocus/matrix.cpp D digikamimageplugins/refocus/matrix.h D digikamimageplugins/refocus/refocus.cpp D digikamimageplugins/refocus/refocus.h
Duplicate menu entires in editor are now fixed. I close this file. Gilles