Version: (using KDE KDE 3.4.0) Installed from: Compiled From Sources OS: Linux When Juk is searching for a cover for a song it is only checking for images in the .kde/share/apps/juk/covers directory. I think alot of people keep a cover.jpg image in each album directory (I do atleast) and it would be great if Juk would first check if that image is available and use it if existing. It would be unneccessary to copy the image to the users local kde directory. Thumbnails would be possible to generate on the fly from the cover.jpg file, thus there would be no need either for a copy of the thumbnail in the users local directory. I have implemented this functionality and I will attach it later after some cleanup. A good side effect of this is that I can now view album covers for albums that have no tag information (artist and album) since the existing cover is found anyway (only based on dirPath). Later on if Juk gets a control panel, setting the cover file name there would be good.
Created attachment 10500 [details] Added scanning of existing cover.jpg in album directory This patch adds functionality in Juk to display existing album covers named "cover.jpg" existing in the album folder. The remove functionality in Juk is disabled for existing album covers, Juk can only remove covers living in Juk:s .kde/share/apps/juk/covers folder. The code will first scan for existing covers and after that it will scan covers saved by Juk.
Fine. You should expand it a bit: Look in tags, allow more name (option to choose image name?) of the cover image in the album folder (i personally use cover.png). Juk shouldn't use his .kde/share/apps/juk/covers folder at all since a lot of other apps share their cover these whay. I used kalbumart to put cover for all my librairy and juk couldn't find them!
Created attachment 24742 [details] Patch to add looking for cover.jpg and built-in cover art. The attached patch (against /trunk) includes support for reading both cover.png and cover.jpg covers in the same directory as a music track, and for reading cover art built-in to MP3 files. It does not move or create the cover.jpg if you use the rename function in JuK, nor is the cover art ever touched/deleted/updated in the .mp3 file (i.e. it's read-only). Covers are searched in the following order: 1. Covers assigned in the cover manager are preferred. 2. If no cover manager cover, then search in the file. 3. If no cover art in the file, then look for cover.jpg or cover.png. Old patch is obsoleted by KDE 4 (it was from when KDE still used CVS even o_O).
SVN commit 807472 by mpyne: Add support for loading more types of covers to JuK trunk. Fixes bug 103118. Now JuK will pull covers from files named cover.jpg or cover.png in the same directory as the music file, or from embedded cover art if present in .mp3 files. BUG:103118 M +119 -8 coverinfo.cpp M +8 -4 coverinfo.h M +5 -1 playlist.cpp M +10 -1 playlistitem.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=807472