Bug 102681 - Odd spacing in toolbar around filter ActionList
Summary: Odd spacing in toolbar around filter ActionList
Status: RESOLVED UNMAINTAINED
Alias: None
Product: kmail
Classification: Applications
Component: filtering (show other bugs)
Version: 1.8
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-28 16:11 UTC by Malte S. Stretz
Modified: 2015-04-12 09:50 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot of the problem (38.44 KB, image/png)
2005-03-28 16:13 UTC, Malte S. Stretz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Malte S. Stretz 2005-03-28 16:11:04 UTC
Version:           1.8 (using KDE 3.4.0, Gentoo)
Compiler:          gcc version 3.3.5 (Gentoo Linux 3.3.5-r1, ssp-3.3.2-3, pie-8.7.7.1)
OS:                Linux (i686) release 2.6.10-gentoo-r4

I have three filters in my toolbar.  In front of the first there always was some odd spacing, after I added the third one, the spacing after the buttons increased.

Screenshot follows.
Comment 1 Malte S. Stretz 2005-03-28 16:13:09 UTC
Created attachment 10390 [details]
Screenshot of the problem
Comment 2 S. Burmeister 2005-03-28 20:07:52 UTC
Does the space increase everytime you close kontact/kmail to tray and re-open it by clicking on the tray icon. That's what I get.
Comment 3 Malte S. Stretz 2005-03-28 20:15:53 UTC
Nope, minimizeing to the tray doesn't change anything.  But after I completely closed KMail once and restarted it, the right spacing (which appeared after I added one filter) is gone.
Comment 4 Andreas Gungl 2005-06-11 22:21:54 UTC
The spacing in front of the first icon is kind of intended. Given that an action list may be empty (at least if no filter is defined) you would like to avoid something like

some action
-- line separator --
ActionList: ...
-- line separator --
another action

because that would look somewhat ugly. That's why I implemented it as having a KActionSeparator in front of the list if the list is not empty. The following should do the trick:

some action
ActionList: ...
-- line separator --
another action

Unfortunately KActionSeparator doesn't allow to use line separators, but only that small spacing. It's a missing piece in kdelibs3 (which I hope to be added in KDE 4).
Well, that at least explains the spacing in front of the first icon. The appropriate source lines are:
kmmainwidget.cpp:148 ff.
kmmainwidget.cpp:3384
You may want to comment line 3384 to get rid of that spacing.

The trailing space increases whenever a filter is added or re-added to the toolbar. I've also found that the space vanishes when you move the action list a bit around (in the toolbar configuration dialog). I tend to blame kdelibs for that, so far I haven't found any code in KMail which could explain the behavior.
Comment 5 Frans Pop 2006-10-22 21:07:44 UTC
I'm still seeing the "ever increasing trailing space" issue in kmail 3.5.5-1.

See Debian bug report http://bugs.debian.org/394719 for details and screenshots.
Comment 6 Laurent Montel 2015-04-12 09:50:49 UTC
Thank you for taking the time to file a bug report.

KMail2 was released in 2011, and the entire code base went through significant changes. We are currently in the process of porting to Qt5 and KF5. It is unlikely that these bugs are still valid in KMail2.

We welcome you to try out KMail 2 with the KDE 4.14 release and give your feedback.