Bug 102398 - $have_arts -> $build_arts fix for configure.in.in never made it into HEAD
Summary: $have_arts -> $build_arts fix for configure.in.in never made it into HEAD
Status: RESOLVED FIXED
Alias: None
Product: kscreensaver
Classification: Miscellaneous
Component: general (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: kscreensaver bugs tracking
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-24 21:13 UTC by Christopher Martin
Modified: 2008-05-19 17:59 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Martin 2005-03-24 21:13:51 UTC
Version:            (using KDE KDE 3.4.0)
Installed from:    Debian testing/unstable Packages
OS:                Linux

kdeartwork/kscreensaver/configure.in.in had a fix checked in 7 months ago, "use correct variable to check for arts, $have_arts -> $build_arts". This fix was checked in to 3_3_BRANCH, but not HEAD. I have checked, and kdeartwork-3.4.0 does not have this fix. Please commit again, and backport to 3_4_BRANCH as well.

Thanks,
Christopher Martin
Comment 1 Thomas Loeber 2005-05-08 13:28:15 UTC
This incorrect check for aRts causes kdeartwork-3.4.0 to skip the compilation of kfiresaver.kss.
Comment 2 Gregorio Guidi 2005-05-09 11:10:39 UTC
*** This bug has been confirmed by popular vote. ***
Comment 3 Modestas Vainius 2005-05-23 22:30:29 UTC
Are you going to release KDE 3.4.1 without this trivial bug fixed? It prevents arts screensavers (only kfiresaver at this time) from being compiled.
Comment 4 Chris Howells 2005-06-11 00:50:18 UTC
SVN commit 424152 by howells:

Forward port correct arts fix
BUG: 102398



 M  +1 -1      configure.in.in  


--- trunk/KDE/kdeartwork/kscreensaver/configure.in.in #424151:424152
@@ -34,7 +34,7 @@
 AM_CONDITIONAL(COMPILE_GL_XSAVERS, test x$have_gl = xyes)
 AM_CONDITIONAL(COMPILE_GL_KSAVERS, test x$ac_cv_kde_qt_has_opengl = xyes)
 AM_CONDITIONAL(COMPILE_X11_KSAVERS, test "x$ac_x_includes" != x && test "x$ac_x_libraries" != x)
-AM_CONDITIONAL(COMPILE_ARTS_KSAVERS, test x$have_arts = xyes)
+AM_CONDITIONAL(COMPILE_ARTS_KSAVERS, test x$build_arts = xyes)
 
 LIBART=
 
Comment 5 Gregorio Guidi 2005-06-11 10:27:13 UTC
Thanks Chris, can you take a look at bug 89387 while you're at it? It's a one-liner for the same file.