Bug 102297 - I am playing in KReversi as "expert" but it saves statistics to the "beginner" records
Summary: I am playing in KReversi as "expert" but it saves statistics to the "beginner...
Status: RESOLVED FIXED
Alias: None
Product: kreversi
Classification: Applications
Component: general (show other bugs)
Version: 1.6
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Inge Wallin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-23 19:14 UTC by Aleksey Kontsevich
Modified: 2005-04-01 22:11 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aleksey Kontsevich 2005-03-23 19:14:42 UTC
Version:           1.6 (using KDE 3.4.0-1.1.kde, Fedora Core release 3 (Heidelberg))
Compiler:          gcc version 3.4.3 20050104 (Red Hat 3.4.3-12)
OS:                Linux (i686) release 2.6.9-1.667

1) I set "Expert" level game
2) Start new game
3) After the game I see the results (win or loss) in "Beginner" statistics
Comment 1 Inge Wallin 2005-03-23 21:29:08 UTC
Was the setting of the game as playing competitively or Casually?
Comment 2 Aleksey Kontsevich 2005-03-25 16:57:52 UTC
The bug appear in both cases
Comment 3 Inge Wallin 2005-03-30 20:03:55 UTC
Ok, I have confirmed this bug and will fix it.

I will just have to wait until my checked out copy of the 3.4 branch is compiled.
Comment 4 Inge Wallin 2005-04-01 22:11:38 UTC
CVS commit by ingwa: 

Fix bug 102297: I am playing in KReversi as "expert" but it saves
statistics to the "beginner" records.

 - let KReversi::m_lowestStrength be an uint instead of bool.

This was a rather embarrasing cut & paste bug.

BUGS: 102297


  M +7 -1      ChangeLog   1.53.2.1
  M +1 -1      kreversi.h   1.20.2.1


--- kdegames/kreversi/ChangeLog  #1.53:1.53.2.1
@@ -1,3 +1,9 @@
-2005-02-18  Inge Wallin  <ingwa@dhcp-254-182.lkpg.cendio.se>
+2005-04-01  Inge Wallin  <inge@lysator.liu.se>
+
+        Fix bug 102297: I am playing in KReversi as "expert" but it saves
+        statistics to the "beginner" records
+        * kreversi.h (m_lowestStrength): uint instead of bool
+
+2005-02-18  Inge Wallin  <inge@lysator.liu.se>
 
         * version.h (KREVERSI_VERSION): Bumped version to 1.6

--- kdegames/kreversi/kreversi.h  #1.20:1.20.2.1
@@ -179,5 +179,5 @@ private:
   bool           m_gameOver;       // True if the game is over
   bool           m_cheating;       // True if the user has changed sides
-  bool           m_lowestStrength; // Lowest strength during the game.
+  uint           m_lowestStrength; // Lowest strength during the game.
   bool           m_competitiveGame;// True if the game has been
                                    // competitive during all moves so far.