Bug 101549 - Rectangular selection and sequence line extension in Sequence Diags.
Summary: Rectangular selection and sequence line extension in Sequence Diags.
Status: RESOLVED FIXED
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Umbrello Development Group
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-15 14:39 UTC by Anton G. Alvedro
Modified: 2014-02-24 17:48 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
'rectselect.png' - Selecting rectangular area selects messages outside the area. (106.27 KB, image/png)
2005-11-23 20:55 UTC, Henk Spaaij
Details
'rectmove' - message jump to the top after moving a rectangular selection (105.31 KB, image/png)
2005-11-23 20:56 UTC, Henk Spaaij
Details
selmove - moving shift-selected messages doesn't move all selected messages (106.45 KB, image/png)
2005-11-23 20:57 UTC, Henk Spaaij
Details
rectselect - Selecting rectangular area selects emssages outside the area. (105.06 KB, image/png)
2005-11-23 21:08 UTC, Henk Spaaij
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anton G. Alvedro 2005-03-15 14:39:52 UTC
Version:           1.3.92 (using KDE 3.2.3, compiled sources)
Compiler:          gcc version 3.3.3
OS:                Linux (i?86) release 2.2.14-5.0

I have a Sequence Diagram with several classes and some messages interchanged between them. I'd like to be able to select the bottom half of them and move them down the diagram to make room for other messages I need to insert in the middle. I've tried the following:

By making a rectangular selection, messages are not selected, just Notes are selected.

Making a multiple item selection by shift-clicking on the messages, and trying to move the selected objects, leads to unpredictable results. Messages are not moved, and some labels move in arbitrary directions.
Comment 1 Henk Spaaij 2005-11-15 22:37:45 UTC
This is a pretty serious bug.

Because of this bugs it becomes difficult to maintain sequence diagrams.
Try inserting a new message in the middle. You'd have to painstakingly select and move each message individually because otherwise your diagram gets totally messed up.

Comment 2 Oliver Kellogg 2005-11-18 19:23:53 UTC
1.3.92 is "ancient" in terms of Umbrello development speed, please use at least
1.4.1 (or better yet, 1.5beta2)
Comment 3 Henk Spaaij 2005-11-23 05:54:49 UTC
Hola, not so quick closing that bug. 
Shouldn't you verify it first?

Anyway, I'm using 1.4.1. This problem is not resolved.
Comment 4 Oliver Kellogg 2005-11-23 17:31:05 UTC
Hm, well I tried with the branches/KDE/3.5 of the KDE Subversion repository
and it works if you select the *object boxes* (not the messages).
However, as far as I recall the corresponding bug was already fixed in 1.4.1.
Comment 5 Henk Spaaij 2005-11-23 20:52:59 UTC
Thanks for checking Oliver.
This error report consists of three issues. Let me clarify my findings with each of them.

1. Moving messages after a rectangular select gives unpredicted result
As soon as you try to move them the selected messages jump to the top of the diagram, messing it up. This is the biggest problem for me.
See attached 'rectmove.png'

2. The rectangular selects messages outside the rectangular area.
This is slightly different behavior from the original bug report because it does now select messages (1.4.1). The reason I mention it is that it still doesn't select the intended messages. 

See attached 'rectselect.png'. 
The selection area is highlighted red. 'terminate' and '__auditAccounts' are outside the selection rectangle but still selected. 

3. Moving messages after shift-selecting.
Doesn't move all the selected messages, only the one you happen to have the cursor over.
In addition, you cannot move lower beyond the point the object bar reaches down, even if other objects have bars reaching down further.
See attached 'shiftmove.png'
- Moving 'createModel' down does not move 'hasModel', although both are selected.
- 'createModel' cannot be moved further down than shown here. (eg, the object bar runs out of rope :). It really should be able to move down further.

Comment 6 Henk Spaaij 2005-11-23 20:55:15 UTC
Created attachment 13621 [details]
'rectselect.png' - Selecting rectangular area selects messages outside the area.
Comment 7 Henk Spaaij 2005-11-23 20:56:36 UTC
Created attachment 13622 [details]
'rectmove' - message jump to the top after moving a rectangular selection
Comment 8 Henk Spaaij 2005-11-23 20:57:56 UTC
Created attachment 13623 [details]
selmove - moving shift-selected messages doesn't move all selected messages

In addition, it doesn't allow you to move beyond the available length of the
object bar.
Comment 9 Henk Spaaij 2005-11-23 21:08:54 UTC
Created attachment 13624 [details]
rectselect - Selecting rectangular area selects emssages outside the area.
Comment 10 Oliver Kellogg 2005-11-23 21:53:39 UTC
Thanks for providing more info.
I confirm your findings.
In fact, one of them I've already fixed a few minutes ago -
> 3. Moving messages after shift-selecting. 
> Doesn't move all the selected messages, only the one you
> happen to have the cursor over. 

I found a bug in ToolBarState::setSelectedWidget() that
caused not all object boxes to be selectable. This is fixed
by the following patch:
http://lists.kde.org/?l=kde-commits&m=113277294919534&w=2

SVN commit 482672 by okellogg:

setSelectedWidget(): Increment the messages iterator only once.
CCMAIL:coolo@kde.org


 M  +0 -1      toolbarstate.cpp  


--- branches/KDE/3.5/kdesdk/umbrello/umbrello/toolbarstate.cpp #482671:482672
@@ -193,7 +193,6 @@
             m_bWidgetSelected = true;
             return true;
         }
-        ++mit;
     }
Comment 11 Joris Steyn 2014-02-24 17:48:20 UTC
Git commit e7f9fa68d6c4d03e0c2751031b3378ff20fae476 by Joris Steyn.
Committed on 24/02/2014 at 17:40.
Pushed by jorissteyn into branch 'master'.

Messages can be selected using the mouse

Selecting and moving multiple messages was already possible using
Control-click. This commit adds mouse support.
Related: bug 106915

M  +59   -43   umbrello/umlscene.cpp
M  +1    -1    umbrello/umlscene.h

http://commits.kde.org/umbrello/e7f9fa68d6c4d03e0c2751031b3378ff20fae476