Bug 101371 - doesn't compile on KDE 3.3
Summary: doesn't compile on KDE 3.3
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-12 16:27 UTC by Jan Ritzerfeld
Modified: 2005-04-14 12:15 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Ritzerfeld 2005-03-12 16:27:56 UTC
Version:           0.10.90 from CVS (using KDE KDE 3.3.2)
Installed from:    SuSE RPMs

There is only one method of KDE 3.4 used:
jan@linux:~/Dev/kdenetwork/kopete> cvs diff kopete/chatwindow/kopetechatwindow.cpp
Index: kopete/chatwindow/kopetechatwindow.cpp
===================================================================
RCS file: /home/kde/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.cpp,v
retrieving revision 1.103
diff -u -3 -p -r1.103 kopetechatwindow.cpp
--- kopete/chatwindow/kopetechatwindow.cpp      7 Mar 2005 21:47:04 -0000       1.103
+++ kopete/chatwindow/kopetechatwindow.cpp      12 Mar 2005 15:26:13 -0000
@@ -545,7 +545,9 @@ void KopeteChatWindow::createTabBar()
                m_tabBar->setSizePolicy( QSizePolicy( QSizePolicy::Expanding, QSizePolicy::Expanding ) );
                m_tabBar->setHoverCloseButton(KGlobal::config()->readBoolEntry( QString::fromLatin1("HoverClose"), false ));
                m_tabBar->setTabReorderingEnabled(true);
+#if KDE_IS_VERSION(3,4,0)
                m_tabBar->setAutomaticResizeTabs(true);
+#endif
                connect( m_tabBar, SIGNAL( closeRequest( QWidget* )), this, SLOT( slotCloseChat( QWidget* ) ) );

                QToolButton* m_rightWidget = new QToolButton( m_tabBar );
Comment 1 Will Stephenson 2005-03-13 14:42:38 UTC
I've committed this fix.
Comment 2 Will Stephenson 2005-04-14 12:15:56 UTC
with regard to your jabber message, "why not KDE_IS_VERSION(3,9,0)?", 3,9,0 means 3.4beta1, whereas 3.4.0 is 3.4rc1 and later.  How many people are still using beta1?  It's not worth changing the code now for them.