Bug 101094 - Left and right keys open multiple instances of feed edit dialog
Summary: Left and right keys open multiple instances of feed edit dialog
Status: RESOLVED FIXED
Alias: None
Product: akregator
Classification: Applications
Component: kontact plugin (show other bugs)
Version: 1.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-08 13:15 UTC by Martin van Es
Modified: 2005-06-27 20:12 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Akregator part in Kontact (149.18 KB, image/jpeg)
2005-04-04 09:29 UTC, Martin van Es
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin van Es 2005-03-08 13:15:21 UTC
Version:           1.0 (using KDE 3.4.0, compiled sources)
Compiler:          gcc version 3.3.5 (Debian 1:3.3.5-8)
OS:                Linux (i686) release 2.6.11

Select a feed, press f2 (or choose edit) keep focus away from raised dialog and press left and right cursor keys. Each press raises a new edit dialog.
Comment 1 Eckhart Wörner 2005-04-01 00:37:15 UTC
Can't reproduce it here.
Are you sure you are able to focus akregator's main window while the feed properties dialogue is still open? I can't.
Comment 2 Teemu Rytilahti 2005-04-03 23:30:31 UTC
I couldn't either reproduce this, closing...
Comment 3 Martin van Es 2005-04-04 09:29:26 UTC
Created attachment 10503 [details]
Akregator part in Kontact

As you can see, the Kontact window still has focus, and I have opened 3 more
property windows by pressing either left or right arrow key while the kontact
window still had focus.
Comment 4 Martin van Es 2005-04-04 09:35:29 UTC
And I had some extra comment to that, but that got discarded when attaching the picture: I think the key to this problem is X-mouse activation. As long as I haven't touched the properties dialog with my mousepointer, the Kontakt window keeps focus. Only after moving over the dialog, the focus can not be stolen by the main kontakt window again.
Comment 5 Eckhart Wörner 2005-04-04 16:47:59 UTC
Well, I can confirm it now, at least partly. This only happens if you are using Akregator inside Kontact, not as a stand-alone application.

I'm not able to activate the main window, but I can still open the context menu of a feed (in the main window) and open the "Feed Properties" dialogue again.
Comment 6 Heinrich Wendel 2005-06-23 20:15:30 UTC
cannot reproduce it in kde 3.4.1, maybe it was fixed in kontact?
Comment 7 Martin van Es 2005-06-24 08:43:49 UTC
I can still reproduce this in 3.4.1.
Comment 8 Heinrich Wendel 2005-06-27 20:12:47 UTC
SVN commit 429447 by lanius:

make properties dialog modal
BUG: 101094

 M  +2 -2      akregator_view.cpp  


--- trunk/KDE/kdepim/akregator/src/akregator_view.cpp #429446:429447
@@ -109,7 +109,7 @@
 
         virtual bool visitTagNode(TagNode* node)
         {
-            TagPropertiesDialog* dlg = new TagPropertiesDialog(0);
+            TagPropertiesDialog* dlg = new TagPropertiesDialog(m_view);
             dlg->setTag(node->tag());
             dlg->exec();
             delete dlg;
@@ -124,7 +124,7 @@
         
         virtual bool visitFeed(Feed* node)
         {
-            FeedPropertiesDialog *dlg = new FeedPropertiesDialog( 0, "edit_feed" );
+            FeedPropertiesDialog *dlg = new FeedPropertiesDialog( m_view, "edit_feed" );
             dlg->setFeed(node);
             dlg->exec();
             delete dlg;