Bug 100763 - slash in file name creates directory instead
Summary: slash in file name creates directory instead
Status: RESOLVED FIXED
Alias: None
Product: kaudiocreator
Classification: Applications
Component: general (show other bugs)
Version: 1.12
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Gerd Fleischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-03 20:18 UTC by Maarten ter Huurne
Modified: 2005-04-11 17:54 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maarten ter Huurne 2005-03-03 20:18:58 UTC
Version:           1.12 (using KDE 3.3.1, SuSE)
Compiler:          gcc version 3.3.1 (SuSE Linux)
OS:                Linux (i686) release 2.4.21-243-default

I had a song title with a slash in it. In the output directory, a subdirectory was created instead of a file name with a slash in it.

Example:
Let's assume track 1 is named "A/B".
Correct output: a file named "01. A/B.ogg"
What happened: a directory named "01. A" containing a file named "B.ogg"
Comment 1 icefox 2005-03-04 03:17:01 UTC
Good one.  Hmm should we change / to - ?
Comment 2 Thiago Macieira 2005-03-04 03:21:43 UTC
We can use %2f where '/' are.
Comment 3 Christian Loose 2005-03-04 09:51:28 UTC
Maybe ask the user like: "Title contained illegal characters. Please rename it"
or something like that.
Comment 4 Maarten ter Huurne 2005-03-05 02:39:50 UTC
Changing "/" to "?" is better than the current situation, but the slash actually belongs in the song title, so I'd still have to rename the file manually afterwards. I let KAudioCreator run unattended as much as possible, so I prefer it doesn't ask me any questions, because then the ripping isn't finished when I return to my PC. So I think escaping slashes as %2f is the solution I'd prefer.
Comment 5 icefox 2005-04-11 17:54:06 UTC
I have fixed the code so any item (artist name, track name, comment) in the output filename that has a / will be changed to %2f.  It is commited to head and will be backported to the 3.4 branch and will be in the next release (3.4.1)