Bug 100424 - importing vcal fails when version string not present
Summary: importing vcal fails when version string not present
Status: RESOLVED INTENTIONAL
Alias: None
Product: korganizer
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-28 10:17 UTC by Daniel Reichhard
Modified: 2008-10-27 01:48 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Reichhard 2005-02-28 10:17:53 UTC
Version:            (using KDE KDE 3.3.92)
Installed from:    Gentoo Packages
Compiler:          gcc version 3.4.3-20050110 (Gentoo Linux 3.4.3.20050110, ssp-3.4.3.20050110-0, pie-8.7.7)
OS:                Linux

importing vcal files fails if "VERSION:1.0" is missing.

it is maybe not a bug because according to the vcal definition it is a mandatory property. nevertheless i think there should be a more failsafe behaviour for importing files.
thank you,
daniel
Comment 1 Daniel Reichhard 2005-02-28 13:00:19 UTC
there is another problem in case the (optional!) UID field is missing in the import file. 
when you add the imported file as a new calendar, and then hide and re-show the resource of that calendar, every time you do this an additional instance of its events is shown (of that resource)

is this worth an own bug report?

regards
Comment 2 Reinhold Kainhofer 2005-02-28 13:08:52 UTC
On Monday 28 February 2005 13:00, Daniel Reichhard wrote:
> is this worth an own bug report?

Yes, definitly. The events should not be duplicated... 

> ------- there is another problem in case the (optional!) UID field is
> missing in the import file. 

yeah, it's optional per vCalendar spec, but the spec also says:

Calendaring applications that do not generate this property in vCalendar 
entities may be limiting their interoperability with other group scheduling 
applications.

In particular, group scheduling with these events will never work, because 
each time the vCalendar file is loaded, a randon uid will be assigned to 
these events, and these uids (by which the events are identified) will not be 
the same  when you load such an event again.

Still, the events should not be duplicated .

Reinhold
Comment 3 Reinhold Kainhofer 2005-07-23 11:08:06 UTC
Actually, the duplication happens for all VTODOs, regardless of whether there is a UID or not. If there is no UID, also events are duplicated.

For loading, we first try to load it as iCalendar (VERSION:2.0), and if that fails as vCalendar (VERSION:1.0). I agree that korganizer should at least try to load such broken files.

Cheers,
Reinhold
Comment 4 Reinhold Kainhofer 2005-07-23 11:50:29 UTC
I thought a bit more on the missing VERSION line, and we can't try to load files without such a version string. The reason is that iCalendar (V 2.0) and vCalendar (V 1.0) have the same structure, but some fields are named and interpreted differently. So, if we simply try to load a file without VERSION: x.x, we don't know if the entries are interpreted as iCalendar or vCalendar. You *can* load an iCalendar file as vCalendar and vice versa, but the events will look broken to the user (but not the computer)!

So we can't ignore a missing version line (the vCalendar and iCalendar specs are pretty clear that these lines are absolutely mandatory!).

Cheers,
Reinhold
Comment 5 Reinhold Kainhofer 2006-11-02 18:56:41 UTC
Reassigning all KOrganizer bug reports and wishes to the newly created 
korganizer-devel mailing list.
Comment 6 FiNeX 2008-09-29 00:11:34 UTC
At this point, if the VERSION line is needed for the importing, shouldn't this report be closed?
Comment 7 Allen Winter 2008-10-27 01:48:36 UTC
yes, I'm closing.