Bug 100335 - Quanta require libxml2.6 in dtdparser but don't fail on configure
Summary: Quanta require libxml2.6 in dtdparser but don't fail on configure
Status: RESOLVED FIXED
Alias: None
Product: quanta
Classification: Miscellaneous
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: András Manţia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-26 22:30 UTC by Yan Morin
Modified: 2005-03-03 17:12 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yan Morin 2005-02-26 22:30:22 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
Compiler:           libxml2-2.5.11-0.fdr.1.rh90.src.rpm

It seems that in kdewebdev/quanta/parsers/dtd/dtdparser.cpp you need libxml2.6 but ./configure don't fail when 2.6 is not install

I can't replace xmlError* errorPtr instead of xmlErrorPtr errorPtr
because event xmlError doesn't exist in my libxml/xmlerror.h 

Redhat package: libxml2-2.5.11-0.fdr.1.rh90.src.rpm
Packager    : kde-redhat Developers <http://kde-redhat.sf.net/>

Reference:
http://sourceforge.net/mailarchive/forum.php?thread_id=6256824&forum_id=36054
http://webcvs.kde.org/kdewebdev/quanta/parsers/dtd/dtdparser.cpp?rev=1.21&view=auto

Report:
dtdparser.cpp: In member function `bool DTDParser::parse()':
dtdparser.cpp:84: `xmlErrorPtr' undeclared (first use this function)
dtdparser.cpp:84: (Each undeclared identifier is reported only once for each
   function it appears in.)
dtdparser.cpp:84: parse error before `=' token
dtdparser.cpp:85: `errorPtr' undeclared (first use this function)
dtdparser.cpp:99: `xmlResetError' undeclared (first use this function)
Comment 1 András Manţia 2005-02-28 19:18:06 UTC
On Saturday 26 February 2005 23:30, Yan Morin wrote:
> It seems that in kdewebdev/quanta/parsers/dtd/dtdparser.cpp you need
> libxml2.6 but ./configure don't fail when 2.6 is not install

Strange, as Quanta has #ifdef's to make it work with libxml 2.5. 

Maybe the global KDE requirements have changed meantime. Can't you 
update libxml to 2.6? I don't think this is a real bug, as 2.5 is quite 
old, 2.6 being available for a while (I have 2.6.17), and it's not a 
bug if we (=KDE) require a newer version of a library.

Andras

Comment 2 Yan Morin 2005-03-01 05:06:47 UTC
libxml2 >= 2.4.8  Recommended  Libxml is an XML library. XML is a metalanguage to design markup languages, such as HTML.

http://kde.org/info/requirements/3.4.php
Comment 3 András Manţia 2005-03-02 10:07:43 UTC
CVS commit by amantia: 

Fix compilation with libxml2 2.5.x.
BUG: 100575, 100335


  M +2 -0      dtdparser.cpp   1.21.2.1


--- kdewebdev/quanta/parsers/dtd/dtdparser.cpp  #1.21:1.21.2.1
@@ -82,4 +82,5 @@ bool DTDParser::parse()
   {
     QString errorStr = i18n("Unknown");
+#ifndef LIBXML_2_5
     xmlErrorPtr errorPtr = xmlGetLastError();
     if (errorPtr != NULL)
@@ -99,4 +100,5 @@ bool DTDParser::parse()
       xmlResetError(errorPtr);
     }
+#endif    
     KMessageBox::error(0, i18n("<qt>Error while parsing the DTD.<br>The error message is:<br><i>%1</i></qt>").arg(errorStr));
     return false;


Comment 4 Yan Morin 2005-03-03 17:12:35 UTC
I confirm, I was able to build it.

And I now have many suggestions in Cervisia support and for <!DOCTYPE> tag, but this is others bug reports ;-)