Summary: | mark thread as Todo doesn't mark all messages in the thread | ||
---|---|---|---|
Product: | [Applications] kmail | Reporter: | Allen Winter <winter> |
Component: | message list | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jtamate |
Priority: | NOR | Keywords: | triaged |
Version: | SVN (3.5 branch) | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Screenshot showing a thread with some messages missing the Todo icon |
Description
Allen Winter
2005-02-05 02:34:05 UTC
Created attachment 9431 [details]
Screenshot showing a thread with some messages missing the Todo icon
I assume they do have the right status, just not the icon? Probably because off the icon merging going on because they are replies? Can you check with the quick search whether they have the right status? Hi Till. Yes, they have the right status according to the quick search. It is just that the Todo icon is missing. PS: In KOrganizer we changed all occurrences of "Todo" with "To-do". Something to consider for KMail. PS2: For consistency, the menu entry "Mark Thread as &todo" should be "Mark Thread as &Todo" or possibly "Mark Thread as &To-do". -Allen On Saturday 05 February 2005 13:46, Allen Winter wrote: > Yes, they have the right status according to the quick search. > It is just that the Todo icon is missing. Ok, so that's a regression from the icon merging. > PS: In KOrganizer we changed all occurrences of "Todo" with "To-do". > Something to consider for KMail. Yeah, although I still prefer "Task", for KOrganizer. For KMail I would prefer To-do, though. > PS2: For consistency, the menu entry "Mark Thread as &todo" should be > "Mark Thread as &Todo" or possibly "Mark Thread as &To-do". The string freeze just started. I'm not sure that such a change would not break it? Till On Saturday 05 February 2005 08:01 am, Till Adam wrote:
> ------- Additional Comments From adam kde org 2005-02-05 14:01 -------
> On Saturday 05 February 2005 13:46, Allen Winter wrote:
>
> > Yes, they have the right status according to the quick search.
> > It is just that the Todo icon is missing.
>
> Ok, so that's a regression from the icon merging.
>
> > PS: In KOrganizer we changed all occurrences of "Todo" with "To-do".
> > Something to consider for KMail.
>
> Yeah, although I still prefer "Task", for KOrganizer. For KMail I would prefer
> To-do, though.
>
> > PS2: For consistency, the menu entry "Mark Thread as &todo" should be
> > "Mark Thread as &Todo" or possibly "Mark Thread as &To-do".
>
> The string freeze just started. I'm not sure that such a change would not
> break it?
>
Probably not worth changing and getting yelled at :)
CVS commit by winterz: String changes for To-do marked messages. I discussed this with Till and he agreed with me to change these strings to make things consistent across PIM. CCBUGS: 98589 M +4 -4 kmmainwidget.cpp 1.321 --- kdepim/kmail/kmmainwidget.cpp #1.320:1.321 @@ -2450,8 +2450,8 @@ void KMMainWidget::setupActions() mStatusMenu->insert( mToggleFlagAction ); - mToggleTodoAction = new KToggleAction(i18n("Mark Message as &Todo"), "kontact_todo", + mToggleTodoAction = new KToggleAction(i18n("Mark Message as &To-do"), "kontact_todo", 0, this, SLOT(slotSetMsgStatusTodo()), actionCollection(), "status_todo"); - mToggleTodoAction->setCheckedState( i18n("Mark Message as Not &Todo") ); + mToggleTodoAction->setCheckedState( i18n("Mark Message as Not &To-do") ); mStatusMenu->insert( mToggleTodoAction ); @@ -2524,8 +2524,8 @@ void KMMainWidget::setupActions() mThreadStatusMenu->insert( mToggleThreadFlagAction ); - mToggleThreadTodoAction = new KToggleAction(i18n("Mark Thread as &todo"), "kontact_todo", + mToggleThreadTodoAction = new KToggleAction(i18n("Mark Thread as &To-do"), "kontact_todo", 0, this, SLOT(slotSetThreadStatusTodo()), actionCollection(), "thread_todo"); - mToggleThreadTodoAction->setCheckedState( i18n("Mark Thread as Not &Todo") ); + mToggleThreadTodoAction->setCheckedState( i18n("Mark Thread as Not &To-do") ); mThreadStatusMenu->insert( mToggleThreadTodoAction ); I've checked it in 1.10.0 (kde 4.1.60 svn trunk 838252) and it marks all the mails in the thread. |