Summary: | birthday reminder displays birthdays too late | ||
---|---|---|---|
Product: | kresources | Reporter: | markus |
Component: | birthdays | Assignee: | Reinhold Kainhofer <reinhold> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
markus
2005-01-13 12:10:38 UTC
Today (14.01.2005) I got another reminder for a birthday on 20.11. It is not clear that the time lag is a fixed delay. Hi Markus, So you have the birthday resource enabled in korganizer. Can you please go the settings dialog of the birthday resource and check which alarm settings are set there? Cheers, Reinhold Reinhold, I have a default of 1048592 days in advance. Maybe this is the reason... But then I wonder why this default is there? I have now set it to 3 days and I will report on this issue when the next birthday occurs. Thanks! Okay, so now we tracked down the reason. I'm experiencing the same wrong alarm default if I add a new birthday resource, so this is completely reproducable... Cheers, Reinhold CVS commit by kainhofe: Properly initialize the values for the birthday resource (if config==0, like it is the case when you create a new resource, the values were never initialized...) BUG: 96903 M +2 -5 resourcekabc.cpp 1.29 --- kdepim/libkcal/resourcekabc.cpp #1.28:1.29 @@ -65,5 +65,5 @@ extern "C" ResourceKABC::ResourceKABC( const KConfig* config ) - : ResourceCalendar( config ) + : ResourceCalendar( config ), mAlarmDays( 1 ), mAlarm( false ) { if ( config ) { @@ -75,9 +75,6 @@ ResourceKABC::ResourceKABC( const KConfi ResourceKABC::ResourceKABC( ) - : ResourceCalendar( 0 ) + : ResourceCalendar( 0 ), mAlarmDays( 1 ), mAlarm( false ) { - mAlarmDays = 1; - mAlarm = false; - init(); } Reinhold, Well, I mistyped in my message above - as I now re-read it. Off course it was clear that the time lag was a constant. Delete "not", set "now" ;-) Thanks for your efforts! A fix time of 26 hours is natural for open source... But tell this to M$... :-)) Best wishes! Markus |