Summary: | Chat window switches to old size after changing tabs | ||
---|---|---|---|
Product: | [Applications] kopete | Reporter: | Malte S. Stretz <mss> |
Component: | Chat Window | Assignee: | Kopete Developers <kopete-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 0.9.0 | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Malte S. Stretz
2004-09-20 22:26:00 UTC
I didn't have this problem with 3.3.0. It appeared as of 3.3.1. An annoying but usable temporary workaround is to: 1) Resize the chat window, 2) Close it, 3) Reopen it. The new size is now the default. Hope the Kopete devs will have this one fixed soon, it doesn't look very good when demoing KDE to Windows users looking for a switch... A similar problem has been reported to SUSE bugzilla: If you configure kopete with iChat theme, and a single window for all chats (so each chat session is its own tab), the window size isn't preserved when you switch tabs. * How to reproduce: Configure kopete with iChat theme, and one window for all chats. Get a couple of chats going. Expand the window size. Switch tabs, and observe the window go back to its original size. Seeing the same issue. Compiled on a RHEL ES3.0 box using Konstruct. KDE is version 3.3.1 and Kopete is 0.9.1. I initially was using iChat theme but switched to xchat theme and the problem persists. Same symptoms and steps to reproduce as reported above. CVS commit by lilachaze: Apply a different fix to bug #59080 which doesn't cause bug #89911. Basically, this is a revert of Jason's commit of 28/05/04 which appears to be bogus; dynamically adding/removing a toolbar is not fundamentally different to adding/removing toolbar buttons or menu items -- we should not do it. Plus the existing fix for bug #59080 disabled this behaviour anyway. CCBUG: 59080 CCBUG: 89911 CCMAIL: matt@matt.rogers.name M +0 -1 chatview.cpp 1.171 M +1 -1 kopetechatwindow.cpp 1.92 --- kdenetwork/kopete/kopete/chatwindow/chatview.cpp #1.170:1.171 @@ -230,5 +230,4 @@ ChatView::ChatView( Kopete::MessageManag mgr->protocol()->capabilities() ); connect( editpart, SIGNAL( toggleToolbar(bool)), this, SLOT(slotToggleRtfToolbar(bool)) ); - connect( this, SIGNAL( windowCreated()), editpart, SLOT(checkToolbarEnabled()) ); m_edit = static_cast<KTextEdit*>( editpart->widget() ); --- kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.cpp #1.91:1.92 @@ -852,5 +852,5 @@ void KopeteChatWindow::setActiveView( QW guiFactory()->addClient(view->msgManager()); createGUI( view->part() ); - readOptions(); + if( m_activeView ) m_activeView->setActive( false ); CVS commit by mattr: Backport the fixes for 59080 and 89911. Should be in KDE 3.3.2 BUG: 89911 CCBUG: 59080 M +0 -1 chatview.cpp 1.155.2.2 M +1 -1 kopetechatwindow.cpp 1.82.2.3 --- kdenetwork/kopete/kopete/chatwindow/chatview.cpp #1.155.2.1:1.155.2.2 @@ -217,5 +217,4 @@ ChatView::ChatView( KopeteMessageManager mgr->protocol()->richTextCapabilities() ); connect( editpart, SIGNAL( toggleToolbar(bool)), this, SLOT(slotToggleRtfToolbar(bool)) ); - connect( this, SIGNAL( windowCreated()), editpart, SLOT(checkToolbarEnabled()) ); m_edit = static_cast<KTextEdit*>( editpart->widget() ); --- kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.cpp #1.82.2.2:1.82.2.3 @@ -847,5 +847,5 @@ void KopeteChatWindow::setActiveView( QW guiFactory()->addClient(view->msgManager()); createGUI( view->part() ); - readOptions(); + if( m_activeView ) m_activeView->setActive( false ); |