Summary: | Albums with duplicate names, second one will not show up | ||
---|---|---|---|
Product: | [Applications] juk | Reporter: | Arne Schmitz <arne.schmitz> |
Component: | general | Assignee: | Scott Wheeler <wheeler> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 2.1 | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Arne Schmitz
2004-09-12 10:24:07 UTC
This I can confirm, but it's almost-a-feature. This is a hard one to fix, because of the following: Consider that you have an album with a compilation of music from various artists. You don't want to have this album show up 12 times in the tree view. The truth is that the Album name is just a very poor mechanism for determining album uniqueness. It would be possible to implement a heuristic for trying to match tracks to their album, but I make no promises. Am Donnerstag, 16. September 2004 06:59 schrieb Michael Pyne: > ------- This I can confirm, but it's almost-a-feature. This is a hard one > to fix, because of the following: > > Consider that you have an album with a compilation of music from various > artists. You don't want to have this album show up 12 times in the tree > view. > > The truth is that the Album name is just a very poor mechanism for > determining album uniqueness. It would be possible to implement a > heuristic for trying to match tracks to their album, but I make no > promises. Ok, I understand this. But then at least please show all tracks from albums of a single name together. At the moment I have two albums with the same name, and only the songs from the first one shows. Arne CVS commit by mpyne: Make the tree view mode playlists use a case-insensitive search, since that's what the underlying map uses. This should fix bug 89339. Reporter: Please let me know if it doesn't. Otherwise I will backport tomorrow and close the bug. CCMAIL:89339@bugs.kde.org M +1 -1 viewmode.cpp 1.34 --- kdemultimedia/juk/viewmode.cpp #1.33:1.34 @@ -355,5 +355,5 @@ void TreeViewMode::slotAddItems(const QS components.clear(); - components.append(PlaylistSearch::Component(item, true, columns, mode)); + components.append(PlaylistSearch::Component(item, false, columns, mode)); PlaylistSearch s(playlists, components, PlaylistSearch::MatchAny, false); CVS commit by mpyne: Backport fix for bug 89339 (Albums with a name that differs only in case don't show up) to KDE 3.3. CCMAIL:89339-done@bugs.kde.org M +1 -1 viewmode.cpp 1.31.2.2 --- kdemultimedia/juk/viewmode.cpp #1.31.2.1:1.31.2.2 @@ -342,5 +342,5 @@ void TreeViewMode::slotAddItem(const QSt mode = PlaylistSearch::Component::Exact; - components.append(PlaylistSearch::Component(item, true, columns, mode)); + components.append(PlaylistSearch::Component(item, false, columns, mode)); PlaylistList playlists; Am Freitag, 17. September 2004 08:11 schrieb Michael Pyne:
> Backport fix for bug 89339 (Albums with a name that differs only in case
> don't show up) to KDE 3.3.
Great! That's it, I didn't realise that the two albums I was talking about had
different cases. :)
Thank you very much!
Arne
|