Summary: | tag editor forgets comments | ||
---|---|---|---|
Product: | [Applications] juk | Reporter: | Michael Daum <micha> |
Component: | general | Assignee: | Scott Wheeler <wheeler> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Michael Daum
2004-08-10 10:06:22 UTC
This is fixed in TagLib 1.2. *** This bug has been marked as a duplicate of 82898 *** Hi Scott, actually I am using libtag1-1.2-1 from debian/unstable and the problem is still there. Why should that be related to tablib? I did not commit the comment text to the mp3 file. I simply switched to another desktop. Comming back to juk it refreshes its X11 appearance with an _empty_ comment text. This is gui related, don't you think so? Micha. D'oh, sorry. That's what I get for processing bugs right after waking up. ;-) I can reproduce this as well. CVS commit by mpyne: Fix bug 86892, where the tag editor loses changes you make whenever you hide the tag editor widget. CCMAIL:86892@bugs.kde.org M +5 -2 tageditor.cpp 1.69 --- kdemultimedia/juk/tageditor.cpp #1.68:1.69 @@ -176,4 +176,6 @@ void TagEditor::slotSetItems(const Playl if(isVisible()) slotRefresh(); + else + m_collectionChanged = true; } @@ -760,8 +762,9 @@ void TagEditor::addItem(const QString &t void TagEditor::showEvent(QShowEvent *e) { - if(m_collectionChanged) + if(m_collectionChanged) { updateCollection(); - slotRefresh(); + } + QWidget::showEvent(e); } CVS commit by mpyne: Backport fix for 86892 (tag editor forgets comments) to KDE 3.3. CCMAIL:86892-done@bugs.kde.org M +5 -2 tageditor.cpp 1.68.2.1 --- kdemultimedia/juk/tageditor.cpp #1.68:1.68.2.1 @@ -176,4 +176,6 @@ void TagEditor::slotSetItems(const Playl if(isVisible()) slotRefresh(); + else + m_collectionChanged = true; } @@ -760,8 +762,9 @@ void TagEditor::addItem(const QString &t void TagEditor::showEvent(QShowEvent *e) { - if(m_collectionChanged) + if(m_collectionChanged) { updateCollection(); - slotRefresh(); + } + QWidget::showEvent(e); } |