Bug 85629

Summary:	warning: Valgrind's pthread_cond_destroy is incomplete
Product:	[Developer tools] valgrind	Reporter:	Peter Seiderer <ps.report>
Component:	general	Assignee:	Julian Seward <jseward>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	2.1.2
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	Patch 1 Patch 2

Description Peter Seiderer 2004-07-21 16:34:08 UTC

Hello,
 
calling pthhread_cond_destroy under valgrind-2.1.2-CVS gives
 
==3119== warning: Valgrind"s pthread_cond_destroy is incomplete
==3119==          (it doesn"t check if the cond is waited on)
==3119==          your program may misbehave as a result
 
 
The attached patch implements this missing check by counting
the number of threads waiting on the specified condition (using
"vg_pthread_cond_t.__vg_c_waiting").
 
The patch works for me (and the two short testprogramms in the second
attachement), hope I did not miss something...
 
Peter

Comment 1 Peter Seiderer 2004-07-21 16:36:49 UTC

Created attachment 6760 [details]
Patch 1

Comment 2 Peter Seiderer 2004-07-21 16:37:27 UTC

Created attachment 6761 [details]
Patch 2

Comment 3 Jeremy Fitzhardinge 2005-01-19 01:05:37 UTC

CVS HEAD valgrind now uses system libpthread, so this bug is moot.